Skip to content

fix: broken syntax highlighting#200

Merged
ReidyT merged 1 commit intomainfrom
197-syntax-highlighting-is-broken
Mar 6, 2024
Merged

fix: broken syntax highlighting#200
ReidyT merged 1 commit intomainfrom
197-syntax-highlighting-is-broken

Conversation

@ReidyT
Copy link
Copy Markdown
Contributor

@ReidyT ReidyT commented Mar 6, 2024

Upgrading the deps seems to solve this problem:

  • @codemirror/lang-python to 6.1.4
  • @uiw/react-codemirror: 4.21.24

It seems that the problem come from codemirror and most particulary about python code…

image image

Trying to update the deps

After updating the deps, there is this error:

image

To solve this:

  1. remove all codemirror dependencies in packages.json (also in resolutions).
  2. run yarn command.
  3. clear yarn and npm cache:
yarn cache clean
npm cache clean --force
  1. clean vite cache npx vite —force.

This seems to also solve the highlight problem.

image

- @codemirror/lang-python to 6.1.4
- @uiw/react-codemirror: 4.21.24
@ReidyT ReidyT self-assigned this Mar 6, 2024
@ReidyT ReidyT linked an issue Mar 6, 2024 that may be closed by this pull request
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReidyT ReidyT changed the title feat(deps): update codemirror deps fix: solve broken syntax highlighting Mar 6, 2024
@ReidyT ReidyT changed the title fix: solve broken syntax highlighting fix: broken syntax highlighting Mar 6, 2024
@ReidyT ReidyT requested review from pyphilia and spaenleh March 6, 2024 11:00
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Let's see if it builds and deploys correctly 😄

@ReidyT ReidyT merged commit 8766c0a into main Mar 6, 2024
@ReidyT ReidyT deleted the 197-syntax-highlighting-is-broken branch March 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Syntax highlighting is broken ?

3 participants