Merge pull request #1484 from jamescowens/integrated_scraper_2

Correct negation error in scraper tooltip for vScrapersNotPublishing

Author: jamescowens

src/qt/bitcoingui.cpp

@@ -1487,7 +1487,7 @@ void BitcoinGUI::updateScraperIcon(int scraperEventtype, int status)
             qsExcludedScrapers = tr("none");
         }
 
-        if (ConvergedScraperStatsCache.Convergence.vScrapersNotPublishing.empty())
+        if (!ConvergedScraperStatsCache.Convergence.vScrapersNotPublishing.empty())
         {
             qsScrapersNotPublishing = QString(((std::string)boost::algorithm::join(ConvergedScraperStatsCache.Convergence.vScrapersNotPublishing, ", ")).c_str());
         }

src/scraper/scraper.cpp

@@ -3645,6 +3645,7 @@ bool ScraperConstructConvergedManifest(ConvergedManifest& StructConvergedManifes
             for (const auto& iScraper : mScrapers)
             {
                 // Only include scrapers enabled in protocol.
+
                 if (iScraper.second.value == "true" || iScraper.second.value == "1")
                 {
                     if (std::find(std::begin(StructConvergedManifest.vExcludedScrapers), std::end(StructConvergedManifest.vExcludedScrapers), iScraper.first)
@@ -3653,6 +3654,7 @@ bool ScraperConstructConvergedManifest(ConvergedManifest& StructConvergedManifes
                             == std::end(StructConvergedManifest.vIncludedScrapers))
                     {
                          StructConvergedManifest.vScrapersNotPublishing.push_back(iScraper.first);
+                         _log(logattribute::INFO, "ScraperConstructConvergedManifest", "Scraper " + iScraper.first + " authorized but not publishing.");
                     }
                 }
             }
@@ -4032,6 +4034,7 @@ bool ScraperConstructConvergedManifestByProject(const NN::WhitelistSnapshot& pro
                         == std::end(StructConvergedManifest.vIncludedScrapers))
                 {
                      StructConvergedManifest.vScrapersNotPublishing.push_back(iScraper.first);
+                     _log(logattribute::INFO, "ScraperConstructConvergedManifesByProject", "Scraper " + iScraper.first + " authorized but not publishing.");
                 }
             }
         }