perf: Perf clients

Author: guanguans

src/Clients/ChanifyClient.php

@@ -23,29 +23,47 @@ class ChanifyClient extends Client
     protected $defined = [
         'token',
         'message',
-        'base_uri',
+        'baseUri',
     ];
 
     /**
      * @var string[]
      */
     protected $options = [
-        'base_uri' => 'https://api.chanify.net/v1/sender',
+        'baseUri' => 'https://api.chanify.net/v1/sender',
     ];
 
     protected function configureOptionsResolver(OptionsResolver $resolver): OptionsResolver
     {
         $resolver = parent::configureOptionsResolver($resolver);
 
         return tap($resolver, function (OptionsResolver $resolver) {
-            $resolver->setNormalizer('base_uri', function (Options $options, $value) {
+            $resolver->setNormalizer('baseUri', function (Options $options, $value) {
                 return trim($value, '/');
             });
         });
     }
 
+    /**
+     * @return $this
+     */
+    public function setBaseUri(string $baseUri)
+    {
+        $this->setOption('baseUri', $baseUri);
+
+        return $this;
+    }
+
+    public function getBaseUri(): string
+    {
+        return $this->getOptions('baseUri');
+    }
+
     public function getRequestUrl(): string
     {
-        return sprintf(static::REQUEST_URL_TEMPLATE, $this->getOptions('base_uri'), $this->getToken());
+        return sprintf(
+            static::REQUEST_URL_TEMPLATE,
+            $this->getBaseUri(),
+            $this->getToken());
     }
 }

src/Clients/Client.php

@@ -37,6 +37,21 @@ abstract class Client implements GatewayInterface, RequestInterface
         'message',
     ];
 
+    /**
+     * @var string[]
+     */
+    protected $required = [];
+
+    /**
+     * @var array
+     */
+    protected $allowedTypes = [];
+
+    /**
+     * @var array
+     */
+    protected $allowedValues = [];
+
     /**
      * Client constructor.
      */
@@ -47,8 +62,17 @@ public function __construct(array $options = [])
 
     protected function configureOptionsResolver(OptionsResolver $resolver): OptionsResolver
     {
-        return tap($resolver, function ($resolver) {
+        return tap($resolver, function (OptionsResolver $resolver) {
             $resolver->setDefined($this->defined);
+            $resolver->setRequired($this->required);
+
+            foreach ($this->allowedTypes as $option => $allowedType) {
+                $resolver->setAllowedTypes($option, $allowedType);
+            }
+
+            foreach ($this->allowedValues as $option => $allowedValue) {
+                $resolver->setAllowedValues($option, $allowedValue);
+            }
         });
     }
 

src/Clients/FeiShuClient.php

@@ -60,9 +60,9 @@ public function getRequestParams(): array
      */
     protected function getSign(string $secret, int $timestamp)
     {
-        $stringToSign = sprintf("%s\n%s", $timestamp, $secret);
+        $key = sprintf("%s\n%s", $timestamp, $secret);
 
-        $hash = hash_hmac('sha256', '', $stringToSign, true);
+        $hash = hash_hmac('sha256', '', $key, true);
 
         return base64_encode($hash);
     }

src/Clients/XiZhiClient.php

@@ -10,8 +10,6 @@
 
 namespace Guanguans\Notify\Clients;
 
-use Symfony\Component\OptionsResolver\OptionsResolver;
-
 class XiZhiClient extends Client
 {
     public const REQUEST_URL_TEMPLATE = [
@@ -35,14 +33,12 @@ class XiZhiClient extends Client
         'type' => 'single',
     ];
 
-    protected function configureOptionsResolver(OptionsResolver $resolver): OptionsResolver
-    {
-        $resolver = parent::configureOptionsResolver($resolver);
-
-        return tap($resolver, function ($resolver) {
-            $resolver->setAllowedValues('type', ['single', 'channel']);
-        });
-    }
+    /**
+     * @var \string[][]
+     */
+    protected $allowedValues = [
+        'type' => ['single', 'channel'],
+    ];
 
     public function getType(): string
     {
@@ -61,6 +57,6 @@ public function setType(string $type)
 
     public function getRequestUrl(): string
     {
-        return sprintf(static::REQUEST_URL_TEMPLATE[$this->getOptions('type')], $this->getToken());
+        return sprintf(static::REQUEST_URL_TEMPLATE[$this->getType()], $this->getToken());
     }
 }