Skip to content

Commit 57a038a

Browse files
committed
refactor(client): remove Conditionable and Tappable traits
- Removed Conditionable and Tappable traits from the Client class - Updated the respective use statements in the Client class - Cleaned up unused code from the Client class
1 parent 1c5b74f commit 57a038a

5 files changed

Lines changed: 2 additions & 108 deletions

File tree

src/Foundation/Client.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,15 @@
1515
use Guanguans\Notify\Foundation\Authenticators\NullAuthenticator;
1616
use Guanguans\Notify\Foundation\Contracts\Authenticator;
1717
use Guanguans\Notify\Foundation\Contracts\Message;
18-
use Guanguans\Notify\Foundation\Traits\Conditionable;
1918
use Guanguans\Notify\Foundation\Traits\HasHttpClient;
2019
use Guanguans\Notify\Foundation\Traits\Makeable;
21-
use Guanguans\Notify\Foundation\Traits\Tappable;
2220
use GuzzleHttp\Exception\GuzzleException;
2321
use Psr\Http\Message\ResponseInterface;
2422

2523
class Client implements Contracts\Client
2624
{
27-
use Conditionable;
2825
use HasHttpClient;
2926
use Makeable;
30-
use Tappable;
3127

3228
private Authenticator $authenticator;
3329

src/Foundation/Message.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,13 @@
1212

1313
namespace Guanguans\Notify\Foundation;
1414

15-
use Guanguans\Notify\Foundation\Traits\Conditionable;
1615
use Guanguans\Notify\Foundation\Traits\HasOptions;
1716
use Guanguans\Notify\Foundation\Traits\Makeable;
18-
use Guanguans\Notify\Foundation\Traits\Tappable;
1917

2018
abstract class Message implements \ArrayAccess, Contracts\Message
2119
{
22-
use Conditionable;
2320
use HasOptions;
2421
use Makeable;
25-
use Tappable;
2622

2723
public function __construct(array $options = [])
2824
{

src/Foundation/Support/helpers.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ function base64_encode_file(string $file): string
2525
* Call the given Closure with the given value then return the value.
2626
*
2727
* @param mixed $value
28+
*
29+
* @see https://github.com/laravel/framework
2830
*/
2931
function tap($value, ?callable $callback = null)
3032
{

src/Foundation/Traits/Conditionable.php

Lines changed: 0 additions & 73 deletions
This file was deleted.

src/Foundation/Traits/Tappable.php

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)