test(rector): Replace usage of Pest Faker functions

- Remove old references to Pest Faker in test files
- Add new implementations of faker and fake functions in Pest.php
- This change updates the testing framework to ensure consistency in random data generation
- Simplifies the adjustability of locales for Faker functions

Author: guanguans

.github/workflows/tests.yml

@@ -9,7 +9,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ ubuntu-latest ]
-        php: [ 8.0, 8.4 ]
+        php: [ 8.0, 8.1, 8.2, 8.3, 8.4 ]
         dependency-version: [ prefer-stable ]
 
     name: P${{ matrix.php }} - ${{ matrix.dependency-version }} - ${{ matrix.os }}

benchmarks/CreateInstanceBench.php

@@ -18,12 +18,11 @@
 use Guanguans\Notify\Bark\Authenticator;
 use Guanguans\Notify\Bark\Client;
 use Guanguans\Notify\Bark\Messages\Message;
+use PhpBench\Attributes\BeforeMethods;
+use PhpBench\Attributes\Revs;
 
-/**
- * @beforeMethods({"setUp"})
- *
- * @revs(10000)
- */
+#[BeforeMethods('setUp')]
+#[Revs(10000)]
 final class CreateInstanceBench
 {
     private \Guanguans\Notify\Foundation\Contracts\Authenticator $authenticator;

benchmarks/SendMessageBench.php

@@ -19,12 +19,11 @@
 use Guanguans\Notify\Bark\Client;
 use Guanguans\Notify\Bark\Messages\Message;
 use GuzzleHttp\Psr7\HttpFactory;
+use PhpBench\Attributes\BeforeMethods;
+use PhpBench\Attributes\Revs;
 
-/**
- * @beforeMethods({"setUp"})
- *
- * @revs(10000)
- */
+#[BeforeMethods('setUp')]
+#[Revs(10000)]
 final class SendMessageBench
 {
     private \Guanguans\Notify\Foundation\Message $message;

composer.json

@@ -94,6 +94,7 @@
         "illuminate/collections": "^9.52 || ^10.0 || ^11.0",
         "illuminate/support": "^9.52 || ^10.0 || ^11.0",
         "infection/extension-installer": "^0.1",
+        "kcs/class-finder": "^0.3",
         "maglnet/composer-require-checker": "^3.8 || ^4.0",
         "mockery/mockery": "^1.6",
         "pestphp/pest": "^1.23 || ^2.0 || ^3.0",
@@ -193,6 +194,7 @@
             "@style-lint",
             "@test",
             "@psalm",
+            "@phpstan",
             "@rector-dry-run",
             "@rector-php82-dry-run",
             "@infection-dirty"

monorepo-builder.php

@@ -46,7 +46,7 @@
         // UpdateChangelogViaPhpReleaseWorker::class,
         CreateGithubReleaseReleaseWorker::class,
         // SetNextMutualDependenciesReleaseWorker::class,
-        // UpdateBranchAliasReleaseWorker::class,
+        UpdateBranchAliasReleaseWorker::class,
         // PushNextDevReleaseWorker::class,
     ]);
 

rector.php

@@ -23,6 +23,7 @@
 use Guanguans\Notify\Foundation\Rectors\ToInternalExceptionRector;
 use Guanguans\Notify\Foundation\Response;
 use GuzzleHttp\RequestOptions;
+use Kcs\ClassFinder\Finder\ComposerFinder;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name\FullyQualified;
@@ -41,6 +42,8 @@
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 use Rector\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector;
 use Rector\Php73\Rector\String_\SensitiveHereNowDocRector;
+use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
+use Rector\Php80\ValueObject\AnnotationToAttribute;
 use Rector\Php82\Rector\Param\AddSensitiveParameterAttributeRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Removing\Rector\Class_\RemoveTraitUseRector;
@@ -60,6 +63,7 @@
 return RectorConfig::configure()
     ->withRootFiles()
     ->withPaths([
+        __DIR__.'/benchmarks',
         __DIR__.'/src',
         __DIR__.'/tests',
         __DIR__.'/composer-updater',
@@ -120,6 +124,14 @@
         new ClassMethodReference(HasOptions::class, 'offsetGet'),
         new ClassMethodReference(Response::class, 'offsetGet'),
     ])
+    ->withConfiguredRule(AnnotationToAttributeRector::class, array_map(
+        static fn (string $class) => new AnnotationToAttribute(class_basename($class), $class, [], true),
+        array_keys(iterator_to_array(
+            (new ComposerFinder)
+                ->inNamespace('PhpBench\Attributes')
+                ->filter(static fn (ReflectionClass $reflectionClass): bool => $reflectionClass->isInstantiable())
+        ))
+    ))
     ->withConfiguredRule(AddSensitiveParameterAttributeRector::class, [
         AddSensitiveParameterAttributeRector::SENSITIVE_PARAMETERS => [
             'accessToken',
@@ -134,48 +146,45 @@
             'webHook',
         ],
     ])
-    ->withConfiguredRule(
-        StringToClassConstantRector::class,
-        array_reduce(
-            [
-                Guanguans\Notify\Foundation\Method::class,
-                RequestOptions::class,
-            ],
-            static fn (array $carry, string $class): array => array_merge(
-                $carry,
-                array_map(
-                    static fn (string $string, string $constant): StringToClassConstant => new StringToClassConstant(
-                        $string,
-                        $class,
-                        $constant,
-                    ),
-                    $constants = (new ReflectionClass($class))->getConstants(),
-                    array_keys($constants),
+    ->withConfiguredRule(RenameFunctionRector::class, [
+        'test' => 'it',
+        'Pest\Faker\faker' => 'faker',
+        'Pest\Faker\fake' => 'fake',
+        // 'faker' => 'fake',
+    ] + array_reduce(
+        [
+            'error_silencer',
+            'value',
+            'base64_encode_file',
+            'tap',
+        ],
+        static function (array $carry, string $func): array {
+            /** @see https://github.com/laravel/framework/blob/11.x/src/Illuminate/Support/functions.php */
+            $carry[$func] = "Guanguans\\Notify\\Foundation\\Support\\$func";
+
+            return $carry;
+        },
+        []
+    ))
+    ->withConfiguredRule(StringToClassConstantRector::class, array_reduce(
+        [
+            Guanguans\Notify\Foundation\Method::class,
+            RequestOptions::class,
+        ],
+        static fn (array $carry, string $class): array => array_merge(
+            $carry,
+            array_map(
+                static fn (string $string, string $constant): StringToClassConstant => new StringToClassConstant(
+                    $string,
+                    $class,
+                    $constant,
                 ),
+                $constants = (new ReflectionClass($class))->getConstants(),
+                array_keys($constants),
             ),
-            [],
         ),
-    )
-    ->withConfiguredRule(
-        RenameFunctionRector::class,
-        [
-            'test' => 'it',
-        ] + array_reduce(
-            [
-                'error_silencer',
-                'value',
-                'base64_encode_file',
-                'tap',
-            ],
-            static function (array $carry, string $func): array {
-                /** @see https://github.com/laravel/framework/blob/11.x/src/Illuminate/Support/functions.php */
-                $carry[$func] = "Guanguans\\Notify\\Foundation\\Support\\$func";
-
-                return $carry;
-            },
-            []
-        )
-    )
+        [],
+    ))
     ->withConfiguredRule(ScalarValueToConstFetchRector::class, array_map(
         static fn (int $value, string $constant): ScalarValueToConstFetch => new ScalarValueToConstFetch(
             new LNumber($value),
@@ -214,13 +223,15 @@ static function (array $carry, string $func): array {
         ],
         StaticClosureRector::class => $staticArrowFunctionPaths,
         StringToClassConstantRector::class => [
+            __DIR__.'/benchmarks',
             __DIR__.'/src/Foundation/Rfc',
             __DIR__.'/src/*/Messages/*.php',
             __DIR__.'/tests',
             __DIR__.'/src/Foundation/Support/Utils.php',
             __DIR__.'/src/Foundation/Response.php',
         ],
         SortAssociativeArrayByKeyRector::class => [
+            __DIR__.'/benchmarks',
             __DIR__.'/src',
             __DIR__.'/tests',
         ],

tests/Foundation/Authenticators/AuthenticatorTest.php

@@ -20,7 +20,6 @@
 use Guanguans\Notify\Foundation\Authenticators\WsseAuthenticator;
 use GuzzleHttp\Psr7\Request;
 use Psr\Http\Message\RequestInterface;
-use function Pest\Faker\faker;
 
 it('can apply the certificate to options', function (): void {
     expect(new CertificateAuthenticator(fixtures_path('cert.pem'), faker()->password))

tests/Foundation/ResponseTest.php

@@ -27,7 +27,6 @@
 use Illuminate\Support\Collection;
 use Illuminate\Support\Fluent;
 use Psr\Http\Message\RequestInterface;
-use function Pest\Faker\faker;
 
 it('can dump debug info', function (): void {
     expect(Response::fromPsrResponse(new \GuzzleHttp\Psr7\Response))

tests/Gitter/ClientTest.php

@@ -19,7 +19,6 @@
 use Guanguans\Notify\Gitter\Authenticator;
 use Guanguans\Notify\Gitter\Client;
 use Guanguans\Notify\Gitter\Messages\Message;
-use function Pest\Faker\faker;
 
 it('can send message', function (): void {
     $authenticator = new Authenticator(

tests/GoogleChat/ClientTest.php

@@ -19,7 +19,6 @@
 use Guanguans\Notify\GoogleChat\Authenticator;
 use Guanguans\Notify\GoogleChat\Client;
 use Guanguans\Notify\GoogleChat\Messages\Message;
-use function Pest\Faker\faker;
 
 it('can send message', function (): void {
     $authenticator = new Authenticator('spaceId', 'key', 'token', 'threadKey');