Skip to content

Remove '&' symbol to fix bug with whiteboard / paper and pencil filter#8649

Open
castillios wants to merge 1 commit into
hackforla:gh-pagesfrom
castillios:fix-whiteboard-and-paper/pencil-filter-bug-8496
Open

Remove '&' symbol to fix bug with whiteboard / paper and pencil filter#8649
castillios wants to merge 1 commit into
hackforla:gh-pagesfrom
castillios:fix-whiteboard-and-paper/pencil-filter-bug-8496

Conversation

@castillios
Copy link
Copy Markdown
Member

@castillios castillios commented May 20, 2026

Fixes #8496

What changes did you make?

  • Removed the '&' by replacing the whiteboard / paper & pencil filter with whiteboard / paper and pencil in _projects/food-oasis.md

Why did you make the changes (we will use this info to test)?

  • The & symbol was causing a bug that prevented the filter from being selected.
  • The query string in place caused the browser to incorrectly read the filter due to the & acting as a delimiter, reading it as:
    • tools = whiteboard / paper and pencil = (empty value)

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Before The filter could not be selected.
Visuals after changes are applied After The filter can now be selected, and Food Oasis is properly displayed.

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b castillios-fix-whiteboard-and-paper/pencil-filter-bug-8496 gh-pages
git pull https://github.com/castillios/website.git fix-whiteboard-and-paper/pencil-filter-bug-8496

@github-actions github-actions Bot added Bug Something isn't working role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels May 20, 2026
@sushma110396 sushma110396 self-requested a review May 23, 2026 19:19
@sushma110396
Copy link
Copy Markdown
Member

ETA: 05/24/2026 EOD
Availability: Weekdays after 6PM PST

@Tomlu60220244
Copy link
Copy Markdown
Member

ETA: 5/24, 2026
Availability: This weekend.

Copy link
Copy Markdown
Member

@sushma110396 sushma110396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! I have verified it locally. All the required steps have been followed:

  • There is a linked issue
  • Screenshots of visual changes look good
  • Branch name is correct

PR approved.

Copy link
Copy Markdown
Member

@Tomlu60220244 Tomlu60220244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! I checked the changes and tested them locally, and everything worked as expected.

What was done well:

  • The branch name and target branch look correct.
  • The PR is properly linked to issue #8496 with 'Fixes #8496'.
  • I tested the filter locally, and 'whiteboard / paper and pencil' appears in the filters list and can be selected correctly.
  • Food Oasis appears in the filtered results.
  • The issue checklist looks complete.
  • I checked for CodeQL alerts and did not find any.
    Nice work! The PR is approved.

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Fix Whiteboard / Paper & Pencil Tool Filter Bug

3 participants