Remove '&' symbol to fix bug with whiteboard / paper and pencil filter#8649
Open
castillios wants to merge 1 commit into
Open
Remove '&' symbol to fix bug with whiteboard / paper and pencil filter#8649castillios wants to merge 1 commit into
castillios wants to merge 1 commit into
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
ETA: 05/24/2026 EOD |
Member
|
ETA: 5/24, 2026 |
sushma110396
approved these changes
May 23, 2026
Member
sushma110396
left a comment
There was a problem hiding this comment.
Change looks good! I have verified it locally. All the required steps have been followed:
- There is a linked issue
- Screenshots of visual changes look good
- Branch name is correct
PR approved.
Tomlu60220244
approved these changes
May 23, 2026
Member
Tomlu60220244
left a comment
There was a problem hiding this comment.
Everything looks great! I checked the changes and tested them locally, and everything worked as expected.
What was done well:
- The branch name and target branch look correct.
- The PR is properly linked to issue #8496 with 'Fixes #8496'.
- I tested the filter locally, and 'whiteboard / paper and pencil' appears in the filters list and can be selected correctly.
- Food Oasis appears in the filtered results.
- The issue checklist looks complete.
- I checked for CodeQL alerts and did not find any.
Nice work! The PR is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8496
What changes did you make?
whiteboard / paper & pencilfilter withwhiteboard / paper and pencilin_projects/food-oasis.mdWhy did you make the changes (we will use this info to test)?
&symbol was causing a bug that prevented the filter from being selected.&acting as a delimiter, reading it as:tools = whiteboard / paperandpencil = (empty value)CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied