Skip to content

Commit 60d2aa5

Browse files
Sjur Brændelandgregkh
authored andcommitted
caif: Fix access to freed pernet memory
[ Upstream commit 96f80d1 ] unregister_netdevice_notifier() must be called before unregister_pernet_subsys() to avoid accessing already freed pernet memory. This fixes the following oops when doing rmmod: Call Trace: [<ffffffffa0f802bd>] caif_device_notify+0x4d/0x5a0 [caif] [<ffffffff81552ba9>] unregister_netdevice_notifier+0xb9/0x100 [<ffffffffa0f86dcc>] caif_device_exit+0x1c/0x250 [caif] [<ffffffff810e7734>] sys_delete_module+0x1a4/0x300 [<ffffffff810da82d>] ? trace_hardirqs_on_caller+0x15d/0x1e0 [<ffffffff813517de>] ? trace_hardirqs_on_thunk+0x3a/0x3 [<ffffffff81696bad>] system_call_fastpath+0x1a/0x1f RIP [<ffffffffa0f7f561>] caif_get+0x51/0xb0 [caif] Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2936d35 commit 60d2aa5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/caif/caif_dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,9 +562,9 @@ static int __init caif_device_init(void)
562562

563563
static void __exit caif_device_exit(void)
564564
{
565-
unregister_pernet_subsys(&caif_net_ops);
566565
unregister_netdevice_notifier(&caif_device_notifier);
567566
dev_remove_pack(&caif_packet_type);
567+
unregister_pernet_subsys(&caif_net_ops);
568568
}
569569

570570
module_init(caif_device_init);

0 commit comments

Comments
 (0)