Merge pull request #41113 from Shion1305/f-aws_dynamodb_table-specify-name-for-gsi-flattenTableGlobalSecondaryIndex

fix(aws_dynamodb_table): Specify "name" for GlobalSecondaryIndex in `flattenTableGlobalSecondaryIndex`

Author: gdavison

.changelog/41113.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_dynamodb_table: Fix perpetual diff on `global_secondary_index` when using `ignore_changes` lifecycle meta-argument
+```

internal/service/dynamodb/table.go

@@ -2608,10 +2608,11 @@ func flattenTableGlobalSecondaryIndex(gsi []awstypes.GlobalSecondaryIndexDescrip
 	for _, g := range gsi {
 		gsi := make(map[string]any)
 
+		gsi[names.AttrName] = aws.ToString(g.IndexName)
+
 		if g.ProvisionedThroughput != nil {
 			gsi["write_capacity"] = aws.ToInt64(g.ProvisionedThroughput.WriteCapacityUnits)
 			gsi["read_capacity"] = aws.ToInt64(g.ProvisionedThroughput.ReadCapacityUnits)
-			gsi[names.AttrName] = aws.ToString(g.IndexName)
 		}
 
 		for _, attribute := range g.KeySchema {

internal/service/dynamodb/table_test.go

@@ -1176,6 +1176,7 @@ func TestAccDynamoDBTable_BillingMode_payPerRequestBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "billing_mode", string(awstypes.BillingModePayPerRequest)),
 					resource.TestCheckResourceAttr(resourceName, "read_capacity", "0"),
 					resource.TestCheckResourceAttr(resourceName, "write_capacity", "0"),
+					resource.TestCheckResourceAttr(resourceName, "global_secondary_index.#", "0"),
 				),
 			},
 			{
@@ -1190,6 +1191,10 @@ func TestAccDynamoDBTable_BillingMode_payPerRequestBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "billing_mode", string(awstypes.BillingModePayPerRequest)),
 					resource.TestCheckResourceAttr(resourceName, "read_capacity", "0"),
 					resource.TestCheckResourceAttr(resourceName, "write_capacity", "0"),
+					resource.TestCheckResourceAttr(resourceName, "global_secondary_index.#", "1"),
+					resource.TestCheckTypeSetElemNestedAttrs(resourceName, "global_secondary_index.*", map[string]string{
+						names.AttrName: "TestTableGSI",
+					}),
 				),
 			},
 		},
@@ -1275,6 +1280,7 @@ func TestAccDynamoDBTable_gsiOnDemandThroughput(t *testing.T) {
 					testAccCheckInitialTableExists(ctx, resourceName, &conf),
 					resource.TestCheckResourceAttr(resourceName, "billing_mode", string(awstypes.BillingModePayPerRequest)),
 					resource.TestCheckTypeSetElemNestedAttrs(resourceName, "global_secondary_index.*", map[string]string{
+						names.AttrName: "att1-index",
 						"on_demand_throughput.0.max_read_request_units":  "5",
 						"on_demand_throughput.0.max_write_request_units": "5",
 					}),
@@ -1292,6 +1298,7 @@ func TestAccDynamoDBTable_gsiOnDemandThroughput(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "billing_mode", string(awstypes.BillingModePayPerRequest)),
 					resource.TestCheckResourceAttr(resourceName, "on_demand_throughput.#", "1"),
 					resource.TestCheckTypeSetElemNestedAttrs(resourceName, "global_secondary_index.*", map[string]string{
+						names.AttrName: "att1-index",
 						"on_demand_throughput.0.max_read_request_units":  "10",
 						"on_demand_throughput.0.max_write_request_units": "10",
 					}),