r/aws_instance: prevent destroy if disable_api_termination is enabled

[johnsonaj]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

When disable_api_termination is enabled terraform should fail to destroy the resource.

This PR prevents destruction of a resource with this enabled

• add a new virtual attribute force_destroy to enable destroying an instance that has disable_api_termination enabled.

resource "aws_instance" "test" {
  ami            = data.aws_ami.test.id
  instance_type  = "t2.medium"
  subnet_id      = aws_subnet.test.id

  disable_api_termination = true
  force_destroy = true
}

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2Instance_disableAPITerminationFinal\|TestAccEC2Instance_basic\|TestAccEC2Instance_disappears' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2Instance_disableAPITerminationFinal\|TestAccEC2Instance_basic\|TestAccEC2Instance_disappears -timeout 360m -vet=off
2025/08/05 13:53:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/05 13:53:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_disappears
=== PAUSE TestAccEC2Instance_disappears
=== RUN   TestAccEC2Instance_disableAPITerminationFinalFalse
=== PAUSE TestAccEC2Instance_disableAPITerminationFinalFalse
=== RUN   TestAccEC2Instance_disableAPITerminationFinalTrue
=== PAUSE TestAccEC2Instance_disableAPITerminationFinalTrue
=== RUN   TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2Instance_basic
=== CONT  TestAccEC2Instance_disableAPITerminationFinalTrue
=== CONT  TestAccEC2Instance_disableAPITerminationFinalFalse
=== CONT  TestAccEC2Instance_disappears
=== CONT  TestAccEC2Instance_basicWithSpot
--- PASS: TestAccEC2Instance_disappears (67.42s)
--- PASS: TestAccEC2Instance_basic (83.15s)
--- PASS: TestAccEC2Instance_basicWithSpot (83.20s)
--- PASS: TestAccEC2Instance_disableAPITerminationFinalTrue (86.98s)
--- PASS: TestAccEC2Instance_disableAPITerminationFinalFalse (92.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	98.673s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

% make testacc TESTARGS='-run=TestAccEC2Instance_disableAPITerminationFinal\|TestAccEC2Instance_basic\|TestAccEC2Instance_disappears\|TestAccEC2Instance_disableAPIStop' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2Instance_disableAPITerminationFinal\|TestAccEC2Instance_basic\|TestAccEC2Instance_disappears\|TestAccEC2Instance_disableAPIStop -timeout 360m -vet=off
2025/08/06 10:22:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/06 10:22:55 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_disappears
=== PAUSE TestAccEC2Instance_disappears
=== RUN   TestAccEC2Instance_disableAPIStop
=== PAUSE TestAccEC2Instance_disableAPIStop
=== RUN   TestAccEC2Instance_disableAPITerminationFinalFalse
=== PAUSE TestAccEC2Instance_disableAPITerminationFinalFalse
=== RUN   TestAccEC2Instance_disableAPITerminationFinalTrue
=== PAUSE TestAccEC2Instance_disableAPITerminationFinalTrue
=== RUN   TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2Instance_basic
=== CONT  TestAccEC2Instance_disableAPITerminationFinalFalse
=== CONT  TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2Instance_disableAPITerminationFinalTrue
=== CONT  TestAccEC2Instance_disableAPIStop
=== CONT  TestAccEC2Instance_disappears
--- PASS: TestAccEC2Instance_disappears (57.70s)
--- PASS: TestAccEC2Instance_basic (72.62s)
--- PASS: TestAccEC2Instance_disableAPITerminationFinalFalse (93.50s)
--- PASS: TestAccEC2Instance_disableAPITerminationFinalTrue (97.58s)
--- PASS: TestAccEC2Instance_basicWithSpot (106.21s)
--- PASS: TestAccEC2Instance_disableAPIStop (108.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	115.340s

[ewbankkit]

LGTM 🚀.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v6.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.