Skip to content

feat: add verification_status attribute to aws_sesv2_email_identity#44045

Merged
ewbankkit merged 4 commits into
hashicorp:mainfrom
stefanfreitag:f-aws_sesv2_email_identity-add-verification-status
Aug 27, 2025
Merged

feat: add verification_status attribute to aws_sesv2_email_identity#44045
ewbankkit merged 4 commits into
hashicorp:mainfrom
stefanfreitag:f-aws_sesv2_email_identity-add-verification-status

Conversation

@stefanfreitag
Copy link
Copy Markdown
Contributor

@stefanfreitag stefanfreitag commented Aug 26, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls are implemented

Description

The resource and data source aws_sesv2_email_identity are enhanced by adding the attribute verification_status. This attribute shows the verification status of the identity. The status can be one of the following:

  • PENDING – The verification process was initiated, but Amazon SES hasn't yet been able to verify the identity.
  • SUCCESS – The verification process completed successfully.
  • FAILED – The verification process failed.
  • TEMPORARY_FAILURE – A temporary issue is preventing Amazon SES from determining the verification status of the identity.
  • NOT_STARTED – The verification process hasn't been initiated for the identity.

Documentation for both has been updated accordingly.

Relations

Closes #41634

References

Output from Acceptance Testing

Datasource

make testacc TESTS=TestAccSESV2EmailIdentityDataSource_ PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityDataSource_'  -timeout 360m -vet=off
2025/08/26 19:36:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/26 19:36:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2EmailIdentityDataSource_tags
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags
=== RUN   TestAccSESV2EmailIdentityDataSource_tags_NullMap
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags_NullMap
=== RUN   TestAccSESV2EmailIdentityDataSource_tags_EmptyMap
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags_EmptyMap
=== RUN   TestAccSESV2EmailIdentityDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccSESV2EmailIdentityDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentityDataSource_tags
=== CONT  TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccSESV2EmailIdentityDataSource_tags_EmptyMap
=== CONT  TestAccSESV2EmailIdentityDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccSESV2EmailIdentityDataSource_tags_NullMap
--- PASS: TestAccSESV2EmailIdentityDataSource_tags (38.20s)
--- PASS: TestAccSESV2EmailIdentityDataSource_tags_EmptyMap (39.83s)
--- PASS: TestAccSESV2EmailIdentityDataSource_tags_NullMap (39.86s)
--- PASS: TestAccSESV2EmailIdentityDataSource_tags_DefaultTags_nonOverlapping (40.12s)
--- PASS: TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_DefaultTag (40.15s)
--- PASS: TestAccSESV2EmailIdentityDataSource_basic (40.52s)
--- PASS: TestAccSESV2EmailIdentityDataSource_tags_IgnoreTags_Overlap_ResourceTag (42.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      42.651s

Resource

make testacc TESTS=TestAccSESV2EmailIdentity_ PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentity_'  -timeout 360m -vet=off
2025/08/26 19:38:53 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/26 19:38:53 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== RUN   TestAccSESV2EmailIdentity_tags_null
=== PAUSE TestAccSESV2EmailIdentity_tags_null
=== RUN   TestAccSESV2EmailIdentity_tags_EmptyMap
=== PAUSE TestAccSESV2EmailIdentity_tags_EmptyMap
=== RUN   TestAccSESV2EmailIdentity_tags_AddOnUpdate
=== PAUSE TestAccSESV2EmailIdentity_tags_AddOnUpdate
=== RUN   TestAccSESV2EmailIdentity_tags_EmptyTag_OnCreate
=== PAUSE TestAccSESV2EmailIdentity_tags_EmptyTag_OnCreate
=== RUN   TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_providerOnly
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_providerOnly
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_overlapping
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_overlapping
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccSESV2EmailIdentity_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccSESV2EmailIdentity_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccSESV2EmailIdentity_tags_ComputedTag_OnCreate
=== PAUSE TestAccSESV2EmailIdentity_tags_ComputedTag_OnCreate
=== RUN   TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== CONT  TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccSESV2EmailIdentity_domainSigning
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_overlapping
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_nonOverlapping
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
=== CONT  TestAccSESV2EmailIdentity_disappears
=== CONT  TestAccSESV2EmailIdentity_basic_domain
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
=== CONT  TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_providerOnly
=== CONT  TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccSESV2EmailIdentity_disappears (94.17s)
=== CONT  TestAccSESV2EmailIdentity_tags_EmptyTag_OnCreate
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (94.17s)
=== CONT  TestAccSESV2EmailIdentity_tags_AddOnUpdate
--- PASS: TestAccSESV2EmailIdentity_basic_domain (100.40s)
=== CONT  TestAccSESV2EmailIdentity_tags_EmptyMap
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_emptyProviderOnlyTag (125.94s)
=== CONT  TestAccSESV2EmailIdentity_tags_null
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_emptyResourceTag (126.05s)
=== CONT  TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_nullOverlappingResourceTag (126.40s)
=== CONT  TestAccSESV2EmailIdentity_tags_ComputedTag_OnCreate
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (153.13s)
=== CONT  TestAccSESV2EmailIdentity_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccSESV2EmailIdentity_domainSigning (169.80s)
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (170.12s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_updateToResourceOnly (187.48s)
--- PASS: TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Replace (196.15s)
--- PASS: TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Replace (196.16s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_updateToProviderOnly (196.74s)
--- PASS: TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_DefaultTag (225.99s)
--- PASS: TestAccSESV2EmailIdentity_tags_ComputedTag_OnCreate (99.61s)
--- PASS: TestAccSESV2EmailIdentity_tags_EmptyMap (138.05s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_nullNonOverlappingResourceTag (86.18s)
--- PASS: TestAccSESV2EmailIdentity_tags_AddOnUpdate (153.23s)
--- PASS: TestAccSESV2EmailIdentity_tags_IgnoreTags_Overlap_ResourceTag (251.49s)
--- PASS: TestAccSESV2EmailIdentity_tags_EmptyTag_OnUpdate_Add (253.10s)
--- PASS: TestAccSESV2EmailIdentity_tags_EmptyTag_OnCreate (163.41s)
--- PASS: TestAccSESV2EmailIdentity_tags_null (131.67s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_nonOverlapping (265.04s)
--- PASS: TestAccSESV2EmailIdentity_tags_ComputedTag_OnUpdate_Add (139.19s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_overlapping (265.39s)
--- PASS: TestAccSESV2EmailIdentity_tags (282.82s)
--- PASS: TestAccSESV2EmailIdentity_tags_DefaultTags_providerOnly (289.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      290.276s

@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XS Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Aug 26, 2025
@stefanfreitag stefanfreitag marked this pull request as ready for review August 27, 2025 05:42
@stefanfreitag stefanfreitag requested a review from a team as a code owner August 27, 2025 05:42
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2025
@ewbankkit ewbankkit self-assigned this Aug 27, 2025
@github-actions github-actions Bot added size/S Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 27, 2025
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2EmailIdentity_basic\|TestAccSESV2EmailIdentityDataSource_basic' PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2EmailIdentity_basic\|TestAccSESV2EmailIdentityDataSource_basic -timeout 360m -vet=off
2025/08/27 08:44:03 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/27 08:44:03 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2EmailIdentityDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityDataSource_basic
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== CONT  TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentity_basic_domain
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
--- PASS: TestAccSESV2EmailIdentityDataSource_basic (13.18s)
--- PASS: TestAccSESV2EmailIdentity_basic_domain (14.82s)
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (14.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	20.415s

@stefanfreitag
Copy link
Copy Markdown
Contributor Author

@ewbankkit thanks for fixing the changelog filename! much appreciated

Copy link
Copy Markdown
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Copy Markdown
Contributor

@stefanfreitag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e47c555 into hashicorp:main Aug 27, 2025
46 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.11.0 milestone Aug 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This functionality has been released in v6.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 28, 2025
@stefanfreitag stefanfreitag deleted the f-aws_sesv2_email_identity-add-verification-status branch August 30, 2025 17:05
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: aws_sesv2_email_identity incorrectly reports verified_for_sending_status

3 participants