feat: Add placement group_id support to EC2 launch templates#44097
Merged
ewbankkit merged 4 commits intoSep 2, 2025
Merged
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
github-actions
Bot
added
needs-triage
aljazmbts
force-pushed
the
f-ec2_launch_template-placement_group_id
branch
from
4df85d5 to
1a462d4
Compare
Add support for specifying placement groups by ID in EC2 launch templates, providing an alternative to the existing group_name parameter. Changes: - Add group_id field to launch template placement configuration - Implement proper conflict validation between group_name and group_id - Add expand/flatten functions for group_id API mapping - Include comprehensive acceptance test coverage: * Test basic group_id functionality * Test migration from group_name to group_id * Test data source support for group_id - Add documentation for new group_id parameter with conflict notes - Add proper changelog entry file (.changelog/38908.txt) This enables users to reference placement groups by their unique ID rather than name, providing more robust infrastructure as code practices and supporting programmatic placement group management. This is particularly useful for placement groups that are shared through Resource Access Manager (RAM), where cross-account access may provide the group ID but not the name. The implementation maintains full backward compatibility with existing group_name configurations while adding the new group_id option with proper validation to prevent conflicting specifications.
aljazmbts
force-pushed
the
f-ec2_launch_template-placement_group_id
branch
from
1a462d4 to
638f3a9
Compare
ewbankkit
added
enhancement
github-actions
Bot
added
the
prioritized
ewbankkit
approved these changes
Sep 2, 2025
Contributor
ewbankkit
left a comment
ewbankkit
left a comment
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2LaunchTemplate_basic\|TestAccEC2LaunchTemplate_Placement_\|TestAccEC2LaunchTemplateDataSource_name' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2LaunchTemplate_basic\|TestAccEC2LaunchTemplate_Placement_\|TestAccEC2LaunchTemplateDataSource_name -timeout 360m -vet=off
2025/09/02 11:43:13 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/02 11:43:13 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccEC2LaunchTemplateDataSource_name
=== PAUSE TestAccEC2LaunchTemplateDataSource_name
=== RUN TestAccEC2LaunchTemplate_basic
=== PAUSE TestAccEC2LaunchTemplate_basic
=== RUN TestAccEC2LaunchTemplate_Placement_groupID
=== PAUSE TestAccEC2LaunchTemplate_Placement_groupID
=== RUN TestAccEC2LaunchTemplate_Placement_groupNameToGroupID
=== PAUSE TestAccEC2LaunchTemplate_Placement_groupNameToGroupID
=== RUN TestAccEC2LaunchTemplate_Placement_hostResourceGroupARN
=== PAUSE TestAccEC2LaunchTemplate_Placement_hostResourceGroupARN
=== RUN TestAccEC2LaunchTemplate_Placement_partitionNum
=== PAUSE TestAccEC2LaunchTemplate_Placement_partitionNum
=== CONT TestAccEC2LaunchTemplateDataSource_name
=== CONT TestAccEC2LaunchTemplate_Placement_partitionNum
=== CONT TestAccEC2LaunchTemplate_Placement_groupNameToGroupID
--- PASS: TestAccEC2LaunchTemplate_Placement_partitionNum (35.57s)
=== CONT TestAccEC2LaunchTemplate_Placement_hostResourceGroupARN
--- PASS: TestAccEC2LaunchTemplate_Placement_groupNameToGroupID (35.64s)
=== CONT TestAccEC2LaunchTemplate_Placement_groupID
--- PASS: TestAccEC2LaunchTemplate_Placement_groupID (20.29s)
=== CONT TestAccEC2LaunchTemplate_basic
--- PASS: TestAccEC2LaunchTemplate_Placement_hostResourceGroupARN (21.74s)
--- PASS: TestAccEC2LaunchTemplateDataSource_name (69.98s)
--- PASS: TestAccEC2LaunchTemplate_basic (19.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 81.488s
Contributor
|
@aljazmbts Thanks for the contribution 🎉 👏. |
Contributor
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
github-actions
Bot
removed
the
prioritized
Contributor
|
This functionality has been released in v6.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
3 tasks
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for specifying placement groups by ID in EC2 launch templates, providing an alternative to the existing group_name parameter.
Changes:
This enables users to reference placement groups by their unique ID rather than name, providing more robust infrastructure as code practices and supporting programmatic placement group management. This is required for placement groups that are shared through Resource Access Manager (RAM).
The implementation maintains full backward compatibility with existing group_name configurations while adding the new group_id option with proper validation to prevent conflicting specifications.
Rollback Plan
This change adds a new optional parameter (
group_id) with proper conflict validation. If rollback is needed:group_namecontinue to work unchangedgroup_idfield can be removed in a future version without breaking existing infrastructuregroup_idback togroup_nameby updating their configurationNo state migration or data conversion is needed for rollback as this is an additive change.
Changes to Security Controls
No changes to security controls. This change only adds a new optional parameter for specifying placement groups by ID rather than name.
Relations
Closes #38908.
Output from Acceptance Testing