Skip to content

New List Resource : aws_nat_gateway#47349

Merged
taruntej-a merged 6 commits into
mainfrom
f-list-resource-aws_nat_gateway
Apr 9, 2026
Merged

New List Resource : aws_nat_gateway#47349
taruntej-a merged 6 commits into
mainfrom
f-list-resource-aws_nat_gateway

Conversation

@taruntej-a
Copy link
Copy Markdown
Contributor

@taruntej-a taruntej-a commented Apr 8, 2026 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Description

Add list implementation for aws_nat_gateway

Relations

Closes #47233

Output from Acceptance Testing

List tests

make testacc K=ec2 TESTS=TestAccVPCNATGateway_List_    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_List_'  -timeout 360m -vet=off
2026/04/09 00:33:36 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 00:33:36 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_List_basic
=== PAUSE TestAccVPCNATGateway_List_basic
=== RUN   TestAccVPCNATGateway_List_includeResource
=== PAUSE TestAccVPCNATGateway_List_includeResource
=== RUN   TestAccVPCNATGateway_List_regionOverride
=== PAUSE TestAccVPCNATGateway_List_regionOverride
=== CONT  TestAccVPCNATGateway_List_basic
=== CONT  TestAccVPCNATGateway_List_regionOverride
=== CONT  TestAccVPCNATGateway_List_includeResource
--- PASS: TestAccVPCNATGateway_List_includeResource (171.57s)
--- PASS: TestAccVPCNATGateway_List_regionOverride (208.08s)
--- PASS: TestAccVPCNATGateway_List_basic (213.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        219.209s

Identity tests

make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_Identity_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_Identity_'  -timeout 360m -vet=off
2026/04/09 00:40:21 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 00:40:21 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_Identity_basic
=== PAUSE TestAccVPCNATGateway_Identity_basic
=== RUN   TestAccVPCNATGateway_Identity_regionOverride
=== PAUSE TestAccVPCNATGateway_Identity_regionOverride
=== RUN   TestAccVPCNATGateway_Identity_ExistingResource_basic
=== PAUSE TestAccVPCNATGateway_Identity_ExistingResource_basic
=== RUN   TestAccVPCNATGateway_Identity_ExistingResource_noRefreshNoChange
=== PAUSE TestAccVPCNATGateway_Identity_ExistingResource_noRefreshNoChange
=== CONT  TestAccVPCNATGateway_Identity_basic
=== CONT  TestAccVPCNATGateway_Identity_ExistingResource_basic
=== CONT  TestAccVPCNATGateway_Identity_regionOverride
=== CONT  TestAccVPCNATGateway_Identity_ExistingResource_noRefreshNoChange
--- PASS: TestAccVPCNATGateway_Identity_regionOverride (222.22s)
--- PASS: TestAccVPCNATGateway_Identity_ExistingResource_noRefreshNoChange (227.06s)
--- PASS: TestAccVPCNATGateway_Identity_basic (258.57s)
--- PASS: TestAccVPCNATGateway_Identity_ExistingResource_basic (283.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        288.758s

Existing tests

make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_basic'  -timeout 360m -vet=off
2026/04/09 17:01:37 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:01:37 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_basic
=== PAUSE TestAccVPCNATGateway_basic
=== CONT  TestAccVPCNATGateway_basic
--- PASS: TestAccVPCNATGateway_basic (229.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        234.343s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_disappears
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_disappears'  -timeout 360m -vet=off
2026/04/09 17:06:23 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:06:23 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_disappears
=== PAUSE TestAccVPCNATGateway_disappears
=== CONT  TestAccVPCNATGateway_disappears
--- PASS: TestAccVPCNATGateway_disappears (224.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        229.791s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_tags      
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_tags'  -timeout 360m -vet=off
2026/04/09 17:11:08 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:11:08 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_tags
=== PAUSE TestAccVPCNATGateway_tags
=== CONT  TestAccVPCNATGateway_tags
--- PASS: TestAccVPCNATGateway_tags (260.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        266.064s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_ConnectivityType_private
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_ConnectivityType_private'  -timeout 360m -vet=off
2026/04/09 17:44:00 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:44:01 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_ConnectivityType_private
=== PAUSE TestAccVPCNATGateway_ConnectivityType_private
=== CONT  TestAccVPCNATGateway_ConnectivityType_private
--- PASS: TestAccVPCNATGateway_ConnectivityType_private (186.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        191.858s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private'  -timeout 360m -vet=off
2026/04/09 17:41:35 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:41:35 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private
=== PAUSE TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private
=== CONT  TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private
--- PASS: TestAccVPCNATGateway_SecondaryPrivateIPAddresses_private (607.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        613.021s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_secondaryPrivateIPAddresses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_secondaryPrivateIPAddresses'  -timeout 360m -vet=off
2026/04/09 17:42:29 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:42:29 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_secondaryPrivateIPAddresses
=== PAUSE TestAccVPCNATGateway_secondaryPrivateIPAddresses
=== CONT  TestAccVPCNATGateway_secondaryPrivateIPAddresses
--- PASS: TestAccVPCNATGateway_secondaryPrivateIPAddresses (668.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        673.435s
make testacc PKG=ec2 TESTS=TestAccVPCNATGateway_secondaryAllocationIDs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_nat_gateway 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNATGateway_secondaryAllocationIDs'  -timeout 360m -vet=off
2026/04/09 17:45:49 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/09 17:45:49 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCNATGateway_secondaryAllocationIDs
=== PAUSE TestAccVPCNATGateway_secondaryAllocationIDs
=== CONT  TestAccVPCNATGateway_secondaryAllocationIDs
--- PASS: TestAccVPCNATGateway_secondaryAllocationIDs (653.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        658.493s

Few tests failed which are not relevant to these changes for example :

=== NAME  TestAccVPCNATGateway_availabilityModeRegionalManual_ReplaceAndRemove
    vpc_nat_gateway_test.go:726: Step 4/4 error: Error running apply: exit status 1
        
        Error: waiting for EC2 NAT Gateway (nat-xxxxxxxxxx) allocation ID (eipalloc-XXXXXXX) disassociate: timeout while waiting for resource to be gone (last state: 'disassociating', timeout: 10m0s): operation error EC2: DescribeNatGateways, context deadline exceeded
        
          with aws_nat_gateway.test,
          on terraform_plugin_test.tf line 53, in resource "aws_nat_gateway" "test":
          53: resource "aws_nat_gateway" "test" {

@taruntej-a taruntej-a self-assigned this Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Apr 8, 2026
@taruntej-a taruntej-a marked this pull request as ready for review April 9, 2026 07:53
@taruntej-a taruntej-a requested a review from a team as a code owner April 9, 2026 07:53
@dosubot dosubot Bot added the new-list-resource Introduces list resource support. label Apr 9, 2026
@taruntej-a taruntej-a added the rnd-ind-provider rnd-ind-provider label Apr 9, 2026
ewbankkit
ewbankkit approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@taruntej-a taruntej-a merged commit 8a69925 into main Apr 9, 2026
78 checks passed
@taruntej-a taruntej-a deleted the f-list-resource-aws_nat_gateway branch April 9, 2026 12:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.41.0 milestone Apr 9, 2026
terraform-aws-provider Bot pushed a commit that referenced this pull request Apr 9, 2026
Update CHANGELOG.md for #47349
54a7c7c
@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

This functionality has been released in v6.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@taruntej-a taruntej-a

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. rnd-ind-provider rnd-ind-provider service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.41.0

Development

Successfully merging this pull request may close these issues.

List: aws_nat_gateway

2 participants

@taruntej-a @ewbankkit