Skip to content

[New List Resource]: aws_eip#47557

Merged
jar-b merged 3 commits into
mainfrom
f-eip-list
Apr 21, 2026
Merged

[New List Resource]: aws_eip#47557
jar-b merged 3 commits into
mainfrom
f-eip-list

Conversation

@jar-b
Copy link
Copy Markdown
Member

@jar-b jar-b commented Apr 21, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds resource identity and list support for aws_eip.

Relations

Closes #47216
Relates #47005

Output from Acceptance Testing

% make t K=ec2 T=TestAccEC2EIP_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-eip-list 🌿...
TF_ACC=1 go1.26.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_'  -timeout 360m -vet=off
2026/04/21 09:46:20 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/21 09:46:20 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccEC2EIP_List_includeResource (53.17s)
=== CONT  TestAccEC2EIP_Identity_regionOverride
--- PASS: TestAccEC2EIP_BYOIPAddress_default (53.60s)
=== CONT  TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
--- PASS: TestAccEC2EIP_disappears (58.84s)
=== CONT  TestAccEC2EIP_association
--- PASS: TestAccEC2EIP_List_regionOverride (58.86s)
--- PASS: TestAccEC2EIP_List_basic (58.98s)
--- PASS: TestAccEC2EIP_networkBorderGroup (68.09s)
--- PASS: TestAccEC2EIP_noVPC (68.51s)
--- PASS: TestAccEC2EIP_basic (68.51s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (68.71s)
--- PASS: TestAccEC2EIP_networkInterface (74.51s)
--- PASS: TestAccEC2EIP_migrateVPCToDomain (76.02s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_basic (89.58s)
--- PASS: TestAccEC2EIP_Identity_basic (91.07s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_noRefreshNoChange (90.62s)
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (46.99s)
--- PASS: TestAccEC2EIP_tags (104.56s)
--- PASS: TestAccEC2EIP_instance (104.84s)
--- PASS: TestAccEC2EIP_Identity_regionOverride (52.53s)
--- PASS: TestAccEC2EIP_Instance_reassociate (120.08s)
--- PASS: TestAccEC2EIP_Instance_notAssociated (120.40s)
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (137.03s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId (164.09s)
--- PASS: TestAccEC2EIP_association (113.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        179.848s

@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Apr 21, 2026
@jar-b jar-b added new-list-resource Introduces list resource support. resource-identity Pertains to resource identity. labels Apr 21, 2026
jar-b added 3 commits April 21, 2026 11:28
```console
% make t K=ec2 T=TestAccEC2EIP_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 tmp3 🌿...
TF_ACC=1 go1.25.9 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_Identity'  -timeout 360m -vet=off
2026/04/20 15:28:45 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/20 15:28:45 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccEC2EIP_Identity_regionOverride (36.51s)
--- PASS: TestAccEC2EIP_Identity_basic (40.08s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_noRefreshNoChange (78.46s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_basic (84.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        91.904s
```

```console
% make t K=ec2 T=TestAccEC2EIP_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-eip-list 🌿...
TF_ACC=1 go1.25.9 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_'  -timeout 360m -vet=off
2026/04/20 16:21:33 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/20 16:21:33 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccEC2EIP_BYOIPAddress_default (60.14s)
--- PASS: TestAccEC2EIP_disappears (70.19s)
--- PASS: TestAccEC2EIP_noVPC (75.00s)
--- PASS: TestAccEC2EIP_networkBorderGroup (75.58s)
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (75.71s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (79.09s)
--- PASS: TestAccEC2EIP_basic (79.27s)
--- PASS: TestAccEC2EIP_migrateVPCToDomain (84.41s)
--- PASS: TestAccEC2EIP_networkInterface (85.47s)
--- PASS: TestAccEC2EIP_Identity_regionOverride (92.44s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_noRefreshNoChange (94.34s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_basic (97.51s)
--- PASS: TestAccEC2EIP_Identity_basic (98.61s)
--- PASS: TestAccEC2EIP_tags (111.93s)
--- PASS: TestAccEC2EIP_instance (114.32s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId (127.92s)
--- PASS: TestAccEC2EIP_Instance_reassociate (135.02s)
--- PASS: TestAccEC2EIP_Instance_notAssociated (134.16s)
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (144.16s)
--- PASS: TestAccEC2EIP_association (151.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        159.186s
```
Adds list support for the `aws_eip` resource.

```console
% make t K=ec2 T=TestAccEC2EIP_List
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-eip-list 🌿...
TF_ACC=1 go1.26.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_List'  -timeout 360m -vet=off
2026/04/21 09:44:13 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/21 09:44:13 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccEC2EIP_List_regionOverride (19.41s)
--- PASS: TestAccEC2EIP_List_includeResource (19.43s)
--- PASS: TestAccEC2EIP_List_basic (19.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        27.100s
```

```console
% make t K=ec2 T=TestAccEC2EIP_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-eip-list 🌿...
TF_ACC=1 go1.26.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_'  -timeout 360m -vet=off
2026/04/21 09:46:20 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/21 09:46:20 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccEC2EIP_List_includeResource (53.17s)
=== CONT  TestAccEC2EIP_Identity_regionOverride
--- PASS: TestAccEC2EIP_BYOIPAddress_default (53.60s)
=== CONT  TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface
--- PASS: TestAccEC2EIP_disappears (58.84s)
=== CONT  TestAccEC2EIP_association
--- PASS: TestAccEC2EIP_List_regionOverride (58.86s)
--- PASS: TestAccEC2EIP_List_basic (58.98s)
--- PASS: TestAccEC2EIP_networkBorderGroup (68.09s)
--- PASS: TestAccEC2EIP_noVPC (68.51s)
--- PASS: TestAccEC2EIP_basic (68.51s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (68.71s)
--- PASS: TestAccEC2EIP_networkInterface (74.51s)
--- PASS: TestAccEC2EIP_migrateVPCToDomain (76.02s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_basic (89.58s)
--- PASS: TestAccEC2EIP_Identity_basic (91.07s)
--- PASS: TestAccEC2EIP_Identity_ExistingResource_noRefreshNoChange (90.62s)
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (46.99s)
--- PASS: TestAccEC2EIP_tags (104.56s)
--- PASS: TestAccEC2EIP_instance (104.84s)
--- PASS: TestAccEC2EIP_Identity_regionOverride (52.53s)
--- PASS: TestAccEC2EIP_Instance_reassociate (120.08s)
--- PASS: TestAccEC2EIP_Instance_notAssociated (120.40s)
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (137.03s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId (164.09s)
--- PASS: TestAccEC2EIP_association (113.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        179.848s
```
@jar-b jar-b marked this pull request as ready for review April 21, 2026 17:13
@jar-b jar-b requested a review from a team as a code owner April 21, 2026 17:13
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 86051cd into main Apr 21, 2026
73 checks passed
@jar-b jar-b deleted the f-eip-list branch April 21, 2026 18:54
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.42.0 milestone Apr 21, 2026
@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. resource-identity Pertains to resource identity. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List: aws_eip

2 participants