Skip to content

Commit 17c2b82

Browse files
committed
refactor: improved name of shared-elements-config type
1 parent ef554fb commit 17c2b82

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/SharedElementRendererData.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import SharedElementSceneData from './SharedElementSceneData';
22
import {
33
SharedElementEventSubscription,
4-
SharedElementConfig,
4+
SharedElementsConfig,
55
SharedElementAnimatedValue,
66
SharedElementTransitionProps,
77
} from './types';
@@ -13,12 +13,12 @@ export default class SharedElementRendererData {
1313
private prevSceneData: SharedElementSceneData | null = null;
1414
private updateSubscribers = new Set<SharedElementRendererUpdateHandler>();
1515
private sceneSubscription: SharedElementEventSubscription | null = null;
16-
private sharedElements: SharedElementConfig = [];
16+
private sharedElements: SharedElementsConfig = [];
1717
private animValue: SharedElementAnimatedValue;
1818

1919
willActivateScene(
2020
sceneData: SharedElementSceneData,
21-
sharedElements: SharedElementConfig,
21+
sharedElements: SharedElementsConfig,
2222
animValue: SharedElementAnimatedValue
2323
): void {
2424
// console.log('SharedElementRendererData.willActivateScene');

src/createSharedElementScene.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import SharedElementSceneData from './SharedElementSceneData';
66
import SharedElementSceneContext from './SharedElementSceneContext';
77
import SharedElementRendererContext from './SharedElementRendererContext';
88
import {
9-
SharedElementItemConfig,
9+
SharedElementsConfig,
1010
SharedElementConfig,
1111
SharedElementAnimationConfig,
1212
SharedElementEventSubscription,
@@ -42,7 +42,7 @@ function normalizeSharedElementAnimationConfig(
4242

4343
function normalizeSharedElementConfig(
4444
sharedElementConfig: any
45-
): SharedElementItemConfig {
45+
): SharedElementConfig {
4646
if (typeof sharedElementConfig === 'string') {
4747
return {
4848
id: sharedElementConfig,
@@ -62,7 +62,7 @@ function normalizeSharedElementConfig(
6262

6363
function normalizeSharedElementsConfig(
6464
sharedElementsConfig: any
65-
): SharedElementConfig | null {
65+
): SharedElementsConfig | null {
6666
if (!sharedElementsConfig) return null;
6767
if (Array.isArray(sharedElementsConfig)) {
6868
if (!sharedElementsConfig.length) return null;

src/types.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ export type SharedElementAnimationConfig = {
2222
align?: SharedElementTransitionAlign;
2323
};
2424

25-
export type SharedElementItemConfig = {
25+
export type SharedElementConfig = {
2626
readonly id: string;
2727
readonly sourceId: string;
2828
readonly animation: SharedElementAnimationConfig;
2929
};
3030

31-
export type SharedElementConfig = SharedElementItemConfig[];
31+
export type SharedElementsConfig = SharedElementConfig[];
3232

3333
export type SharedElementAnimatedValue = any;
3434

0 commit comments

Comments
 (0)