Add new texture filtering mode "Auto Max Quality"#14789
Conversation
…ering for best quality. It does this by enforcing mipmapping and minification filters, and always autogenerates mipmaps and enforces anisotropic filtering for all modes (if that's separately enabled). This looks nice and flicker free in most games without any additional tweaking, including GTA and Burnout which have long been painfully flickery in the distance due to undersampling. Needs a bit more testing before merge, maybe. Fixes #13888
| if (maxPossibleMipmaps != maxLevelToGenerate) { | ||
| maxLevelToGenerate = maxPossibleMipmaps; | ||
| } |
There was a problem hiding this comment.
nit: the check is not needed :)
There was a problem hiding this comment.
Oh yeah, I only had it so I could set a breakpoint there, while debugging it.
|
Texture MAX Size is also a good name? |
|
Test result are very impressive. |
unknownbrackets
left a comment
unknownbrackets
left a comment
There was a problem hiding this comment.
Makes sense. I think the only case where we wouldn't want to do this is when the mip levels are the same size, which is a different problem anyway.
Should we change the default? A lot of games don't use mipmaps, but likely only for space reasons. I haven't tried this yet, but I'd expect it to be a universal improvement.
-[Unknown]
|
Didn't had time to try it yet, but how special cases like #6357 are handled? |
|
No worse than now. Ultimately, because those cases (Tactics Ogre was another) don't have mip sizes of decreasing size, we detect that they're invalid for use as mip levels. In those cases, I think we'll force mipmaps off. So it won't be changed by this pull. -[Unknown] |
|
It's got positive effects even without the extra mip generation on the non-vulkan backends, so I'm gonna merge as is and add the mip generation later. |
ghost
mentioned this pull request
5 participants
When enabled, tweaks texture filtering for best quality (in a huge majority of games, at least).
It does this by enforcing mipmapping and minification filtering, enforces anisotropic filtering for all mip selection modes (if that's separately enabled) and (if the backend supports it, currently Vulkan) autogenerates mipmaps.
This looks nice and flicker free in most games without any additional tweaking, including GTA and Burnout which have long been painfully flickery in the distance due to undersampling.
Needs a bit more testing before merge, and will add mip gen to more APIs.
Also, maybe this should have a different name, though "Auto Max Quality" is at least pretty descriptive.
Fixes #13888