Skip to content

Enforce Escaping in PHPCS #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeselander merged 3 commits into from
Jan 6, 2020
Merged

Enforce Escaping in PHPCS #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04e6046
Enforce escaping within PHPCS
mikeselander Dec 27, 2019
0bd3329
Adapt tests to passing after proving that the sniff is integrated cor…
mikeselander Dec 27, 2019
dfd4acb
Merge branch 'master' into enforce-escaping
mikeselander Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Unreleased (0.8.0)

### Added:
- Added `WordPress.Security.EscapeOutput` PHPCS rule #166

### Updated
- Bumped `stylelint-config-wordpress` package to v15 from v13 #165

Expand Down
4 changes: 2 additions & 2 deletions HM/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
assignment in conditionals.
-->
<exclude name="WordPress.PHP.YodaConditions" />

<exclude name="WordPress.Security.EscapeOutput" />
</rule>

<!-- Prefer alignment over line length. -->
Expand All @@ -61,6 +59,8 @@
</properties>
</rule>

<rule ref="WordPress.Security.EscapeOutput" />

<rule ref="WordPress.Security.PluginMenuSlug" />
<rule ref="WordPress.Security.PluginMenuSlug.Using__FILE__">
<type>error</type>
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/pass/inc/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function run_test( $tester ) {
continue;
}

echo $y;
echo esc_html( $y );
}

return $foo;
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/pass/tests/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function run_test( $tester ) {
continue;
}

echo $y;
echo esc_html( $y );
}

return $foo;
Expand Down