fix(locale): fixed typo for "monday" in arabic by alaadotsol · Pull Request #1067 · iamkun/dayjs

alaadotsol · 2020-09-22T15:44:11Z

It's الإثنين instead of الإتنين

Sources:

https://en.wikipedia.org/wiki/Names_of_the_days_of_the_week
https://shorturl.at/bnxQ2
I am arab (Moroccan).

UPDATE: It seems like other arabic countries got this problem as well, converting this into draft until I fix it in all of them.

codecov · 2020-09-22T15:45:53Z

Codecov Report

Merging #1067 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1067   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1522      1547   +25     
  Branches       321       328    +7     
=========================================
+ Hits          1522      1547   +25

Impacted Files	Coverage Δ
src/locale/ar-kw.js	`100.00% <ø> (ø)`
src/locale/ar-ma.js	`100.00% <ø> (ø)`
src/index.js	`100.00% <0.00%> (ø)`
src/plugin/utc/index.js	`100.00% <0.00%> (ø)`
src/plugin/timezone/index.js	`100.00% <0.00%> (ø)`
src/plugin/objectSupport/index.js	`100.00% <0.00%> (ø)`
src/plugin/advancedFormat/index.js	`100.00% <0.00%> (ø)`
src/locale/en-SG.js
src/locale/en-sg.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94af9af...5daef94. Read the comment docs.

iamkun · 2020-09-28T02:16:03Z

Hi, if you have finished this PR, you can remove the draft label so that it could get reviewed.

alaadotsol · 2020-09-28T12:48:31Z

Hi, if you have finished this PR, you can remove the draft label so that it could get reviewed.

Hey! Sorry for the delay, I had some work going on, I will work on it as soon as possible, which will be in the next 2 days or so ~ It's not really a big deal it's just a typo, but for middle-eastern users might look a bit weird.

iamkun · 2020-09-30T01:37:07Z

-  weekdays: 'الأحد_الإتنين_الثلاثاء_الأربعاء_الخميس_الجمعة_السبت'.split('_'),
+  weekdays: 'الأحد_الإثنين_الثلاثاء_الأربعاء_الخميس_الجمعة_السبت'.split('_'),
  months: 'يناير_فبراير_مارس_أبريل_ماي_يونيو_يوليوز_غشت_شتنبر_أكتوبر_نونبر_دجنبر'.split('_'),
  weekdaysShort: 'احد_اتنين_ثلاثاء_اربعاء_خميس_جمعة_سبت'.split('_'),


I don't know Arabic, just a simple question, should we update this as well? Or to keep the same with https://github.com/moment/moment/blob/develop/locale/ar-kw.js

Yeah, الإتنين should be الإثنين, that's how it's spelled in Arabic, I honestly don't know where moment got these locales but if you check other Arabic countries ar_* they're all spelling it الإثنين, it's the same in all Arabic countries.

Here it is in wikipedia: https://cutt.ly/Wf9BSuk

What I really ask is should we update weekdaysShort in ar-kw as well?

Yeah yes, I updated it ^^

## [1.9.2](v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](#1129)) ([be505c2](be505c2)) * export type of duration plugin ([#1094](#1094)) ([2c92e71](2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](#1101)) ([7937ccd](7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](#1107)) ([fe90bb6](fe90bb6)), closes [#1105](#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](#1108)) ([cc87eff](cc87eff)) * Fix typo for "monday" in arabic ([#1067](#1067)) ([2e1e426](2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](#1099)) ([b1a0294](b1a0294)) * update Breton [br] locale relativeTime config ([#1103](#1103)) ([b038bfd](b038bfd)) * update Catalan [ca] locale ordinal ([73da380](73da380)) * update German [de] locale relativeTime config ([#1109](#1109)) ([f6e771b](f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](#1106)) ([16937d1](16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](f56783e))

iamkun · 2020-10-13T08:52:17Z

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2)) * export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff)) * Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294)) * update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd)) * update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380)) * update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))

## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13) ### Bug Fixes * add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2)) * export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71)) * Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd)) * Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105) * fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff)) * Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426)) * support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294)) * update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd)) * update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380)) * update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b)) * update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1)) * Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))

fix(locale): fixed typo for "monday" in arabic

c26149b

alaadotsol marked this pull request as draft September 22, 2020 15:45

fix(locale): kuwait weekday monday

ec3fb46

alaadotsol marked this pull request as ready for review September 29, 2020 19:27

iamkun reviewed Sep 30, 2020

View reviewed changes

fix(locales): weekdays short kuwait's monday

5daef94

iamkun merged commit 2e1e426 into iamkun:dev Sep 30, 2020

iamkun added the released label Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(locale): fixed typo for "monday" in arabic#1067

fix(locale): fixed typo for "monday" in arabic#1067
iamkun merged 3 commits into
iamkun:devfrom
alaadotsol:patch-1

alaadotsol commented Sep 22, 2020 •

edited

Loading

Uh oh!

codecov Bot commented Sep 22, 2020 •

edited

Loading

Uh oh!

iamkun commented Sep 28, 2020

Uh oh!

alaadotsol commented Sep 28, 2020 •

edited

Loading

Uh oh!

iamkun Sep 30, 2020

Uh oh!

alaadotsol Sep 30, 2020 •

edited

Loading

Uh oh!

iamkun Sep 30, 2020

Uh oh!

alaadotsol Sep 30, 2020

Uh oh!

iamkun Sep 30, 2020

Uh oh!

iamkun commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alaadotsol commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamkun commented Sep 28, 2020

Uh oh!

alaadotsol commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamkun Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

alaadotsol Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamkun Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

alaadotsol Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

iamkun Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

iamkun commented Oct 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alaadotsol commented Sep 22, 2020 •

edited

Loading

codecov Bot commented Sep 22, 2020 •

edited

Loading

alaadotsol commented Sep 28, 2020 •

edited

Loading

alaadotsol Sep 30, 2020 •

edited

Loading