[minor] Add failing test for nested and chained produce calls#935
Merged
mweststrate merged 2 commits intoimmerjs:mainfrom Jan 15, 2023
Merged
[minor] Add failing test for nested and chained produce calls#935mweststrate merged 2 commits intoimmerjs:mainfrom
mweststrate merged 2 commits intoimmerjs:mainfrom
Conversation
✅ Deploy Preview for quizzical-lovelace-dcbd6a canceled.
|
3 tasks
mweststrate
changed the title
Collaborator
|
Putting on hold for now, as the test looks legit but contrived, so some context on the original problem this is addressing would be needed to be able to figure this one out. |
Collaborator
|
Ah, this might relate to #917, will check on top of that |
mweststrate
changed the title
Contributor
Author
|
Thanks for looking at this. This test is capturing the bug I described in #936, which has a bit more context as to what conditions triggered this error. |
Collaborator
|
NOTE: will merge this diff, which will break main, but otherwise I have to cherrypick the test and the original attribution to @jpallen would be lost :) |
mweststrate
added a commit
that referenced
this pull request
Jan 15, 2023
… produces, to prevent 'hiding' drafts. Fixes #935
Contributor
|
🎉 This PR is included in version 9.0.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.