fix: cap mempool priority overflow (#494)

* fix: cap mempool priority overflow

* assgin maxPriority once

Author: beer-1

x/dynamic-fee/ante/fee.go

@@ -1,6 +1,8 @@
 package ante
 
 import (
+	stdmath "math"
+
 	"cosmossdk.io/errors"
 	"cosmossdk.io/math"
 
@@ -28,6 +30,26 @@ func NewMempoolFeeChecker(
 		keeper,
 	}
 }
+
+var maxPriority math.LegacyDec
+
+func init() {
+	maxPriority = math.LegacyNewDecFromInt(math.NewInt(stdmath.MaxInt64))
+}
+
+func priorityFromGasPrice(gasPrice math.LegacyDec) int64 {
+	if !gasPrice.IsPositive() {
+		return 1
+	}
+
+	scaledPriority := gasPrice.MulInt64(1_000_000)
+	if scaledPriority.GTE(maxPriority) {
+		return stdmath.MaxInt64
+	}
+
+	return math.Max(scaledPriority.TruncateInt64(), 1)
+}
+
 func (fc MempoolFeeChecker) CheckTxFeeWithMinGasPrices(ctx sdk.Context, tx sdk.Tx) (sdk.Coins, int64, error) {
 	feeTx, ok := tx.(sdk.FeeTx)
 	if !ok {
@@ -69,8 +91,8 @@ func (fc MempoolFeeChecker) CheckTxFeeWithMinGasPrices(ctx sdk.Context, tx sdk.T
 
 			gasPriceFromTotalFee := math.LegacyNewDecFromInt(totalFeeBaseAmount).Quo(math.LegacyNewDec(int64(gas))) //nolint: gosec
 
-			// priority is max(gasPriceFromTotalFee * 1e6, 1)
-			priority = math.Max(gasPriceFromTotalFee.MulInt64(1000000).TruncateInt64(), 1)
+			// priority is max(gasPriceFromTotalFee * 1e6, 1), capped to int64 bounds.
+			priority = priorityFromGasPrice(gasPriceFromTotalFee)
 
 			if gasPriceFromTotalFee.LT(baseGasPrice) {
 				return nil, 0, errors.Wrapf(

x/dynamic-fee/ante/fee_test.go

@@ -3,6 +3,7 @@ package ante_test
 import (
 	"context"
 	"fmt"
+	stdmath "math"
 
 	"cosmossdk.io/math"
 
@@ -147,3 +148,43 @@ func (suite *AnteTestSuite) TestEnsureMempoolFees() {
 	_, _, err = fc.CheckTxFeeWithMinGasPrices(suite.ctx, tx)
 	suite.Require().NotNil(err, "Decorator should have errored on too low fee for local gasPrice")
 }
+
+func (suite *AnteTestSuite) TestEnsureMempoolFees_PriorityOverflowCapped() {
+	suite.SetupTest()
+	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
+
+	fc := ante.NewMempoolFeeChecker(TestAnteKeeper{
+		pools: map[string][]math.Int{
+			"rare": {
+				math.NewInt(5_000_000_000_000_000_000),
+				math.OneInt(),
+			},
+		},
+		weights: map[string][]math.LegacyDec{
+			"rare": {
+				math.LegacyOneDec(),
+				math.LegacyOneDec(),
+			},
+		},
+		baseDenom:    baseDenom,
+		baseGasPrice: math.LegacyZeroDec(),
+	})
+
+	priv1, _, addr1 := testdata.KeyTestPubAddr()
+	msg := testdata.NewTestMsg(addr1)
+
+	suite.Require().NoError(suite.txBuilder.SetMsgs(msg))
+	suite.txBuilder.SetFeeAmount(sdk.NewCoins(sdk.NewCoin("rare", math.OneInt())))
+	suite.txBuilder.SetGasLimit(1)
+
+	privs, accNums, accSeqs := []cryptotypes.PrivKey{priv1}, []uint64{0}, []uint64{0}
+	tx, err := suite.CreateTestTx(privs, accNums, accSeqs, suite.ctx.ChainID())
+	suite.Require().NoError(err)
+
+	suite.ctx = suite.ctx.WithIsCheckTx(true)
+	suite.ctx = suite.ctx.WithMinGasPrices(nil)
+
+	_, priority, err := fc.CheckTxFeeWithMinGasPrices(suite.ctx, tx)
+	suite.Require().NoError(err)
+	suite.Require().Equal(int64(stdmath.MaxInt64), priority)
+}