Closed
Conversation
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d1992, 5de334c, and da730c7. This commit squashes them into a single commit. PR-URL: nodejs#990 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
LGTM. |
Contributor
|
Considering discussion in #942, I'd say land it. Personally, I'm not really sure what to test for landing npm bumps. |
cjihrig
pushed a commit
that referenced
this pull request
Mar 6, 2015
PR-URL: #1080 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was actually a pretty significant release for a number of reasons, because I tried to merge or otherwise resolve as many of npm's outstanding pull requests as I could. The CHANGELOG.md has the full details, but here are the bits most pertinent to io.js:
145af65#4887 Replace calls to the
node-gypscript bundled with npm by passing the--node-gyp=/path/to/node-gypoption to npm. Swap inpangypor a versionof
node-gypmodified to work better with io.js without having to touchnpm's code! (@ackalker)
2f6a1df#1999 Only run
stopandstartscripts (plus their pre- and post- scripts) when there's no
restartscriptdefined. This makes it easier to support graceful restarts of services
managed by npm. (@watilde /
@scien)
448efd0#2853 Add support for
--devand--prodtonpm ls, so that you can list only the trees of production ordevelopment dependencies, as desired.
(@watilde)
a0a8777#7463 Split the list printed by
npm run-scriptinto lifecycle scripts and scripts directly invoked vianpm run-script. (@watilde)a5edc17#6749
init-package-json@1.3.1:Support for passing scopes to
npm initso packages are initialized as partof that scope / organization / team. (@watilde)
Includes a cherry-picked version of @cjihrig's combined
node-gyppatch. It would be really great to get rid of the need for that patch sooooon.The 3 features at the end are what caused the semver-minor bump, but do read the full CHANGELOG for a lengthy discussion of why the second change might be considered a breaking change, but isn't in fact. Semver can be pretty nuanced.