test: loosen infinite loop detect condition#1681
Closed
yosuke-furukawa wants to merge 1 commit intonodejs:masterfrom
yosuke-furukawa:hotfix/test-dgram-send-callback-recursive
Closed
test: loosen infinite loop detect condition#1681yosuke-furukawa wants to merge 1 commit intonodejs:masterfrom yosuke-furukawa:hotfix/test-dgram-send-callback-recursive
yosuke-furukawa wants to merge 1 commit intonodejs:masterfrom
yosuke-furukawa:hotfix/test-dgram-send-callback-recursive
Conversation
brendanashworth
added
test
Member
Author
|
jenkins ci: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/663/ I don't have a permission to run jenkins ci. How do I get the permission?? |
Member
|
@rvagg Can you give @yosuke-furukawa access? @yosuke-furukawa When you have an account, go here, fill in the 'user' and 'branch' fields ('yosuke-furukawa' and 'hotfix/test-dgram-send-callback-recursive' in this case), leave the other fields at their defaults, click 'Build' and go get a cup of coffee - you'll have plenty of time to finish it. |
yosuke-furukawa
changed the title
Contributor
Contributor
|
CI seems happier. The windows failures are unrelated afaik, I'll try to root them out today. |
Contributor
|
Landed in 4e2f999 thanks! |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Fixes: nodejs#1675 PR-URL: nodejs#1681 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #1675