feat(cli): fail cap update on uninstalled cordova dependencies (#8032)

Author: benmccarty91

cli/src/android/update.ts

@@ -47,7 +47,7 @@ export async function updateAndroid(config: Config): Promise<void> {
     await copyTask(config, platform);
   }
   await handleCordovaPluginsJS(cordovaPlugins, config, platform);
-  await checkPluginDependencies(plugins, platform);
+  await checkPluginDependencies(plugins, platform, config.app.extConfig.cordova?.failOnUninstalledPlugins);
   await installGradlePlugins(config, capacitorPlugins, cordovaPlugins);
   await handleCordovaPluginsGradle(config, cordovaPlugins);
   await writeCordovaAndroidManifest(cordovaPlugins, config, platform);

cli/src/cordova.ts

@@ -470,7 +470,11 @@ function removeOuterTags(str: string) {
   return str.substring(start, end);
 }
 
-export async function checkPluginDependencies(plugins: Plugin[], platform: string): Promise<void> {
+export async function checkPluginDependencies(
+  plugins: Plugin[],
+  platform: string,
+  failOnMissingDeps = false,
+): Promise<void> {
   const pluginDeps: Map<string, string[]> = new Map();
   const cordovaPlugins = plugins.filter((p) => getPluginType(p, platform) === PluginType.Cordova);
   const incompatible = plugins.filter((p) => getPluginType(p, platform) === PluginType.Incompatible);
@@ -517,6 +521,10 @@ export async function checkPluginDependencies(plugins: Plugin[], platform: strin
       msg += `\n  ${c.strong(plugin)} is missing dependencies:\n` + deps.map((d) => `    - ${d}`).join('\n');
     }
 
+    if (failOnMissingDeps) {
+      fatal(`${msg}\n`);
+    }
+
     logger.warn(`${msg}\n`);
   }
 }

cli/src/declarations.ts

@@ -638,6 +638,15 @@ export interface CapacitorConfig {
      * @since 1.3.0
      */
     preferences?: { [key: string]: string | undefined };
+
+    /**
+     * Fail on cap update/sync if the CLI detects that a cordova plugin
+     * has uninstalled dependencies.
+     *
+     * @default false
+     * @since 7.4.0
+     */
+    failOnUninstalledPlugins?: boolean;
   };
 
   /**

cli/src/ios/update.ts

@@ -50,7 +50,7 @@ async function updatePluginFiles(config: Config, plugins: Plugin[], deployment:
     await copyTask(config, platform);
   }
   await handleCordovaPluginsJS(cordovaPlugins, config, platform);
-  await checkPluginDependencies(plugins, platform);
+  await checkPluginDependencies(plugins, platform, config.app.extConfig.cordova?.failOnUninstalledPlugins);
   if ((await checkPackageManager(config)) === 'SPM') {
     await generateCordovaPackageFiles(cordovaPlugins, config);
     await generatePackageFile(config, plugins);