Int often not enough when returning number from Aggregate functions#92
Closed
walker wants to merge 1 commit intoj4mie:masterfrom
walker:master
Closed
Int often not enough when returning number from Aggregate functions#92walker wants to merge 1 commit intoj4mie:masterfrom walker:master
walker wants to merge 1 commit intoj4mie:masterfrom
walker:master
Conversation
ghost
assigned
Collaborator
|
Thank you for the pull request and issue report. I have closed the issue in commit f4b107c with a slightly different implementation, which I feel is a little easier to read. |
Author
|
Ah, sure thing. I would usually implement to match f4b107c. My pull request looked the way it did as I was trying to match what I saw as idiorm's "style". Thanks for closing this so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I don't know that anything besides an int and a float are necessary for some of these functions, but int was definitely too limiting.