exiting with code 1 when failing validation

Author: antialias

lib/main.js

@@ -73,7 +73,12 @@ const normalizeTheme = (value, defaultValue) => {
     .description("Validate your resume's schema")
     .action(async () => {
       const resume = await getResume({ path: program.resume });
-      await validate(resume);
+      try {
+        await validate(resume);
+      } catch (e) {
+        console.error(e.message)
+        process.exitCode = 1;
+      }
     });
 
   program

lib/main.test.js

@@ -48,6 +48,22 @@ describe('cli configuration', () => {
       "
     `);
   });
+  describe('validate', () => {
+    it('should fail when trying to validate an invalid resume specified by the --resume option', async () => {
+      await expect(
+        run('validate --resume /test-resumes/invalid-resume.json'),
+      ).rejects.toEqual(
+        expect.objectContaining({
+          code: 1,
+        }),
+      );
+    });
+    it('should validate a resume specified by the --resume option', async () => {
+      const output = await run('validate --resume /test-resumes/resume.json');
+      expect(output.stdout).toMatchInlineSnapshot(`""`);
+      expect(output.stderr).toMatchInlineSnapshot(`""`);
+    });
+  });
   describe('export', () => {
     it('should export a resume from the path specified by --resume to the path specified immediately after the export command', async () => {
       const output = await run(

lib/test-utils/mocked-volume-builder.js

@@ -5,6 +5,11 @@ module.exports = ({ mount = '/' } = {}) => {
   return Volume.fromJSON(
     flat(
       {
+        'invalid-resume.json': JSON.stringify({
+          notAValidKey: {
+            foo: 'bar',
+          },
+        }),
         'resume.json': JSON.stringify({
           basics: {
             name: 'thomas',

lib/validate.js

@@ -11,13 +11,8 @@ const getSchema = function () {
     return schema;
   } // Return the default schema, if a custom schema wasn't specified
 
-  try {
-    const customSchemaPath = path.join(process.cwd(), process.argv[index + 1]);
-    return JSON.parse(fs.readFileSync(customSchemaPath, { encoding: 'utf-8' }));
-  } catch (error) {
-    console.log(error.message);
-    process.exit();
-  }
+  const customSchemaPath = path.join(process.cwd(), process.argv[index + 1]);
+  return JSON.parse(fs.readFileSync(customSchemaPath, { encoding: 'utf-8' }));
 };
 
 const reporter = ZSchemaErrors.init();