Skip to content

Commit 5750366

Browse files
committed
API parameters with escaped characters fail in IE7-9. Fix #19
1 parent 1816033 commit 5750366

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

CHANGELOG

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
codebird-js - changelog
22
=======================
33

4-
2.4.1-rc1 (2013-06-23)
4+
2.4.1 (not yet released)
55
+ Pass JSHint validation
66
+ #15 Allow to assign custom proxy address
7+
- #19 API parameters with escaped characters fail in IE7-9
78

89
2.4.0 (2013-06-15)
910
+ Support multipart file uploads

codebird.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* A Twitter library in JavaScript
33
*
44
* @package codebird
5-
* @version 2.4.1-rc1
5+
* @version 2.4.1
66
* @author J.M. <me@mynetx.net>
77
* @copyright 2010-2013 J.M. <me@mynetx.net>
88
*
@@ -126,7 +126,7 @@ var Codebird = function () {
126126
/**
127127
* The current Codebird version
128128
*/
129-
var _version = "2.4.1-rc1";
129+
var _version = "2.4.1";
130130

131131
/**
132132
* Sets the OAuth consumer key and secret (App key)
@@ -774,14 +774,14 @@ var Codebird = function () {
774774
var oauth_params = _clone(sign_base_params);
775775
for (key in params) {
776776
value = params[key];
777-
sign_base_params[key] = _url(value);
777+
sign_base_params[key] = value;
778778
}
779779
var keys = _ksort(sign_base_params);
780780
var sign_base_string = "";
781781
for (var i = 0; i < keys.length; i++) {
782782
key = keys[i];
783783
value = sign_base_params[key];
784-
sign_base_string += key + "=" + value + "&";
784+
sign_base_string += key + "=" + _url(value) + "&";
785785
}
786786
sign_base_string = sign_base_string.substring(0, sign_base_string.length - 1);
787787
var signature = _sha1(httpmethod + "&" + _url(method) + "&" + _url(sign_base_string));

0 commit comments

Comments
 (0)