fix(travis): validate TRAVIS_COMMIT if TRAVIS_PULL_REQUEST_SHA is not…#3094
Merged
johnjbarton merged 1 commit intokarma-runner:masterfrom Jul 31, 2018
Merged
fix(travis): validate TRAVIS_COMMIT if TRAVIS_PULL_REQUEST_SHA is not…#3094johnjbarton merged 1 commit intokarma-runner:masterfrom
johnjbarton merged 1 commit intokarma-runner:masterfrom
Conversation
… set. Looks like the pre-merge travis run sets TRAVIS_PULL_REQUEST_SHA but the post-merge run does not. In the post-merge the TRAVIS_COMMIT should be the PR, so validate it.
Contributor
Author
|
This change is needed to allow our post-submit CI runs to pass. |
zzo
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… set.
Looks like the pre-merge travis run sets TRAVIS_PULL_REQUEST_SHA but the post-merge run does not.
In the post-merge the TRAVIS_COMMIT should be the PR, so validate it.