Skip to content

Commit bb100a1

Browse files
Apply suggestions from code review
fix domains Co-authored-by: tembo[bot] <208362400+tembo[bot]@users.noreply.github.com>
1 parent 178d97f commit bb100a1

File tree

3 files changed

+17
-19
lines changed

3 files changed

+17
-19
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Alternatively, to link a local copy of the repo:
4949

5050
```sh
5151
# Clone
52-
$ git clone https://www.github.com/kernel/kernel-node-sdk
52+
$ git clone https://github.com/kernel/kernel-node-sdk
5353
$ cd kernel-node-sdk
5454

5555
# With yarn
@@ -99,7 +99,7 @@ the changes aren't made through the automated pipeline, you may want to make rel
9999

100100
### Publish with a GitHub workflow
101101

102-
You can release to package managers by using [the `Publish NPM` GitHub action](https://www.github.com/kernel/kernel-node-sdk/actions/workflows/publish-npm.yml). This requires a setup organization or repository secret to be set up.
102+
You can release to package managers by using [the `Publish NPM` GitHub action](https://github.com/kernel/kernel-node-sdk/actions/workflows/publish-npm.yml). This requires a setup organization or repository secret to be set up.
103103

104104
### Publish manually
105105

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
This library provides convenient access to the Kernel REST API from server-side TypeScript or JavaScript.
66

7-
The REST API documentation can be found on [docs.kernel.com](https://docs.kernel.com). The full API of this library can be found in [api.md](api.md).
7+
The REST API documentation can be found on [docs.kernel.com](https://www.kernel.sh/docs/api-reference). The full API of this library can be found in [api.md](api.md).
88

99
It is generated with [Stainless](https://www.stainless.com/).
1010

@@ -400,7 +400,7 @@ This package generally follows [SemVer](https://semver.org/spec/v2.0.0.html) con
400400

401401
We take backwards-compatibility seriously and work hard to ensure you can rely on a smooth upgrade experience.
402402

403-
We are keen for your feedback; please open an [issue](https://www.github.com/kernel/kernel-node-sdk/issues) with questions, bugs, or suggestions.
403+
We are keen for your feedback; please open an [issue](https://github.com/kernel/kernel-node-sdk/issues) with questions, bugs, or suggestions.
404404

405405
## Requirements
406406

tests/index.test.ts

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -329,23 +329,21 @@ describe('instantiate client', () => {
329329
process.env['KERNEL_BASE_URL'] = ' '; // blank
330330
const client = new Kernel({ apiKey: 'My API Key' });
331331
expect(client.baseURL).toEqual('https://api.kernel.com/');
332-
});
333-
334-
test('env variable with environment', () => {
335-
process.env['KERNEL_BASE_URL'] = 'https://example.com/from_env';
332+
expect(client.baseURL).toEqual('https://api.onkernel.com/');
333+
});
336334

337-
expect(
338-
() => new Kernel({ apiKey: 'My API Key', environment: 'production' }),
339-
).toThrowErrorMatchingInlineSnapshot(
340-
`"Ambiguous URL; The \`baseURL\` option (or KERNEL_BASE_URL env var) and the \`environment\` option are given. If you want to use the environment you must pass baseURL: null"`,
341-
);
335+
test('blank env variable', () => {
336+
process.env['KERNEL_BASE_URL'] = ' '; // blank
337+
const client = new Kernel({ apiKey: 'My API Key' });
338+
expect(client.baseURL).toEqual('https://api.onkernel.com/');
339+
});
342340

343-
const client = new Kernel({
344-
apiKey: 'My API Key',
345-
baseURL: null,
346-
environment: 'production',
347-
});
348-
expect(client.baseURL).toEqual('https://api.kernel.com/');
341+
test('env variable with environment', () => {
342+
@@ -345,7 +345,7 @@ describe('instantiate client', () => {
343+
baseURL: null,
344+
environment: 'production',
345+
});
346+
expect(client.baseURL).toEqual('https://api.onkernel.com/');
349347
});
350348

351349
test('in request options', () => {

0 commit comments

Comments
 (0)