GHA: Only do a single install step

Author: jnvsor

.github/actions/kint-setup/action.yml

@@ -8,13 +8,20 @@ inputs:
   php-ini-values:
     required: false
     default: ''
+  npm-version:
+    required: false
+    default: null
 runs:
   using: composite
   steps:
     - uses: actions/setup-node@v4
+      if: inputs.npm-version
       with:
-        node-version: latest
+        node-version: ${{ inputs.npm-version }}
         cache: npm
+    - run: npm ci
+      shell: bash
+      if: inputs.npm-version
     - uses: shivammathur/setup-php@v2
       with:
         php-version: ${{ inputs.php-version }}
@@ -29,12 +36,10 @@ runs:
         key: ${{ runner.os }}-${{ inputs.php-version < 8.1 }}-${{ hashFiles('./composer.lock') }}
     # On old versions we only run tests so strip everything else out
     - run: |
-        composer remove --dev $(composer show --no-interaction --locked --name-only --direct)
+        composer remove --dev --no-install $(composer show --no-interaction --locked --name-only --direct)
         composer config platform.php 7.4
-        composer require --dev phpunit/phpunit ^9
+        composer require --dev --no-install phpunit/phpunit ^9
       shell: bash
       if: inputs.php-version < 8.1
-    # On new versions just composer install
     - run: composer install
       shell: bash
-      if: inputs.php-version >= 8.1

.github/workflows/tests.yml

@@ -10,6 +10,7 @@ jobs:
         name: Kint setup
         with:
           php-version: 8.4
+          npm-version: latest
       - run: |
           composer format
           git status
@@ -26,6 +27,7 @@ jobs:
         with:
           php-version: 8.4
           php-ini-values: 'phar.readonly=Off'
+          npm-version: latest
       - run: |
           composer clean
           composer build
@@ -40,6 +42,7 @@ jobs:
         name: Kint setup
         with:
           php-version: 8.4
+          npm-version: latest
       - run: composer analyze
   test-basic:
     name: 'Basic test ${{ matrix.php-coverage }}'

CONTRIBUTING.md

@@ -16,11 +16,9 @@ When expanding Kint, keep in mind its main priorities:
 ### Development instructions
 
 ```sh
-composer install # Install dependencies
+composer install && npm ci # Install dependencies
 composer format  # Format code style
 composer analyze # Static analysis
 ./vendor/bin/phpunit tests # Run unit tests
 composer build   # Build JS/CSS resources, and the final phar file
 ```
-
-Note: Full format and build depends on `npm` being in your `$PATH`.

composer.json

@@ -42,8 +42,6 @@
         }
     },
     "scripts": {
-        "post-update-cmd": "npm ci",
-        "post-install-cmd": "@post-update-cmd",
         "clean": [
             "rm -rf resources/compiled/",
             "rm -rf build/"