drop unnecessary metric attribute (#16045)

Author: dprotaso

pkg/activator/handler/concurrency_reporter.go

@@ -228,7 +228,6 @@ func (cr *ConcurrencyReporter) reportToMetricsBackend(key types.NamespacedName,
 			metrics.ConfigurationNameKey.With(configurationName),
 			metrics.RevisionNameKey.With(revName),
 			metrics.K8sNamespaceKey.With(ns),
-			metrics.ActivatorKeyValue,
 		)),
 	)
 }

pkg/activator/handler/concurrency_reporter_test.go

@@ -565,7 +565,6 @@ func TestMetricsReported(t *testing.T) {
 		metrics.ConfigurationNameKey.With("config-"+rev1.Name),
 		metrics.RevisionNameKey.With(rev1.Name),
 		metrics.K8sNamespaceKey.With(rev1.Namespace),
-		metrics.ActivatorKeyValue,
 	)
 
 	metricstest.AssertMetrics(

pkg/activator/handler/metric_handler.go

@@ -52,7 +52,6 @@ func (h *MetricHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		metrics.ConfigurationNameKey.With(configurationName),
 		metrics.RevisionNameKey.With(rev.Name),
 		metrics.K8sNamespaceKey.With(rev.Namespace),
-		metrics.ActivatorKeyValue,
 	)
 
 	h.nextHandler.ServeHTTP(w, r)

pkg/activator/handler/metric_handler_test.go

@@ -96,7 +96,6 @@ func TestRequestMetricHandler(t *testing.T) {
 					metrics.ConfigurationNameKey.With(rev.Labels[serving.ConfigurationLabelKey]),
 					metrics.RevisionNameKey.With(rev.Name),
 					metrics.K8sNamespaceKey.With(rev.Namespace),
-					metrics.ActivatorKeyValue,
 				}
 
 				if diff := cmp.Diff(want, got, cmpOpts...); diff != "" {

pkg/metrics/key.go

@@ -28,5 +28,4 @@ var (
 	RouteTagNameKey      = attributekey.String("kn.route.tag")
 	K8sNamespaceKey      = attributekey.String("k8s.namespace.name")
 	K8sPodIPKey          = attributekey.String("k8s.pod.ip")
-	ActivatorKeyValue    = attributekey.Bool("kn.activator.proxy").With(true)
 )