linting and cleanup

Author: Alexander-Kita

pkg/reconciler/route/resources/service_test.go

@@ -28,7 +28,6 @@ import (
 	netapi "knative.dev/networking/pkg/apis/networking"
 	netv1alpha1 "knative.dev/networking/pkg/apis/networking/v1alpha1"
 	netcfg "knative.dev/networking/pkg/config"
-	"knative.dev/pkg/apis"
 	"knative.dev/pkg/kmeta"
 	pkgnet "knative.dev/pkg/network"
 	apiConfig "knative.dev/serving/pkg/apis/config"
@@ -291,7 +290,6 @@ func TestMakeK8SService(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			ingress := &netv1alpha1.Ingress{Status: tc.status}
 			ctx := config.ToContext(context.Background(), testConfig())
-			ctx = apis.WithDryRun(ctx)
 
 			got, err := MakeK8sService(ctx, tc.route, tc.tagName, ingress, tc.private)
 			if tc.expectErr && err == nil {

pkg/reconciler/route/table_test.go

@@ -3388,7 +3388,6 @@ func NewTestReconciler(ctx context.Context, listers *Listers, cmw configmap.Watc
 		cfg.Domain = v.(*config.Domain)
 	}
 
-	ctx = apis.WithDryRun(ctx)
 	return routereconciler.NewReconciler(ctx,
 		logging.FromContext(ctx),
 		servingclient.Get(ctx),

test/e2e/service_validation_test.go

@@ -33,7 +33,6 @@ import (
 	v1test "knative.dev/serving/test/v1"
 
 	. "knative.dev/serving/pkg/testing/v1"
-	rtesting "knative.dev/serving/pkg/testing/v1"
 )
 
 func withInvalidContainer() ServiceOption {
@@ -71,7 +70,7 @@ func TestServiceDryRunValidationWithInvalidPodSpec(t *testing.T) {
 
 // PatchServiceWithDryRun patches the existing service passed in with the applied mutations running in dryrun mode.
 // Returns the latest service object
-func PatchServiceWithDryRun(t testing.TB, clients *test.Clients, service *v1.Service, fopt ...rtesting.ServiceOption) (svc *v1.Service, err error) {
+func PatchServiceWithDryRun(t testing.TB, clients *test.Clients, service *v1.Service, fopt ...ServiceOption) (svc *v1.Service, err error) {
 	newSvc := service.DeepCopy()
 	for _, opt := range fopt {
 		opt(newSvc)