Delete IsFromDbSet for subquery (#72)

Author: kurnakovv

src/Kuker.Analyzers/Rules/Kuk0005TagWithCallSiteOnExecutionAnalyzer.cs

@@ -269,31 +269,36 @@ CompilationSymbolsModel model
             {
                 return false;
             }
+
             IMethodSymbol methodSymbol = GetInvocationMethodSymbol(invocation, context);
+
             if (methodSymbol == null)
             {
                 return false;
             }
+
             IMethodSymbol originalMethod = methodSymbol.ReducedFrom ?? methodSymbol;
+
             if (!s_queryLambdaMethodNames.Contains(originalMethod.Name))
             {
                 return false;
             }
+
             if (!IsQueryableOperatorMethod(originalMethod, model))
             {
                 return false;
             }
+
             ExpressionSyntax sourceExpression = GetQuerySourceExpression(invocation, originalMethod);
+
             if (sourceExpression == null)
             {
                 return false;
             }
+
             ITypeSymbol sourceType = context.SemanticModel.GetTypeInfo(sourceExpression).Type;
-            if (!ImplementsIQueryable(sourceType, model))
-            {
-                return false;
-            }
-            return IsFromDbSet(sourceExpression, context, model);
+
+            return ImplementsIQueryable(sourceType, model);
         }
 
         private static IMethodSymbol GetInvocationMethodSymbol(

tests/Kuker.Analyzers.Tests/Rules/Kuk0005TagWithCallSiteOnExecutionAnalyzerTests.cs

@@ -427,6 +427,52 @@ select c
             _appDbContext.Users.Any(u => _appDbContext.Companies.Any(c => c.Id == u.Id) && u.Id == id)
         ).ToArray();
         """, 14, 5, 14, 95)]
+    [InlineData("""
+        // Execution inside execute (subquery) OK
+        IQueryable<User> baseQuery = GetUserQuery();
+
+        UserSummary[] result = await baseQuery.TagWithCallSite()
+            .Select(u => new UserSummary
+            {
+                Id = u.Id,
+                Name = u.Name,
+
+                CompanyName = _appDbContext.Companies
+                    .Where(c => c.Id == u.CompanyId)
+                    .Select(c => c.Name)
+                    .FirstOrDefault(),
+
+                RelatedUsers = _appDbContext.Users
+                    .Where(x => x.CompanyId == u.CompanyId)
+                    .OrderBy(x => x.Name)
+                    .Select(x => x.Name)
+                    .ToArray(),
+            })
+            .ToArrayAsync();
+        """, 0, 0, 0, 0)]
+    [InlineData("""
+        // Execution inside execute (subquery) violation
+        IQueryable<User> baseQuery = GetUserQuery();
+
+        UserSummary[] result = await baseQuery
+            .Select(u => new UserSummary
+            {
+                Id = u.Id,
+                Name = u.Name,
+
+                CompanyName = _appDbContext.Companies
+                    .Where(c => c.Id == u.CompanyId)
+                    .Select(c => c.Name)
+                    .FirstOrDefault(),
+
+                RelatedUsers = _appDbContext.Users
+                    .Where(x => x.CompanyId == u.CompanyId)
+                    .OrderBy(x => x.Name)
+                    .Select(x => x.Name)
+                    .ToArray(),
+            })
+            .ToArrayAsync();
+        """, 16, 30, 33, 20)]
 #pragma warning restore RCS0053,SA1117 // Fix formatting of a list
     public async Task RunAsync(string inputQuery, int startLine, int startColumn, int endLine, int endColumn)
     {
@@ -483,6 +529,17 @@ public class Company
                 public long Id { get; set; }
                 public string Name { get; set; }
             }
+
+            public class UserSummary
+            {
+                public long Id { get; set; }
+
+                public string Name { get; set; }
+
+                public string CompanyName { get; set; }
+
+                public string[] RelatedUsers { get; set; }
+            }
         
             public class AppDbContext : DbContext
             {