Combine consecutive isset and unset (#59685)

Co-authored-by: Lucas Michot <lucas@zaiple.com>

Author: lucasmichot

pint.json

@@ -31,6 +31,8 @@
         "class_definition": true,
         "class_reference_name_casing": true,
         "clean_namespace": true,
+        "combine_consecutive_issets": true,
+        "combine_consecutive_unsets": true,
         "compact_nullable_type_declaration": true,
         "concat_space": true,
         "constant_case": {

src/Illuminate/Foundation/Testing/TestCase.php

@@ -48,13 +48,11 @@ public function createApplication()
 
         $this->traitsUsedByTest = class_uses_recursive(static::class);
 
-        if (isset(CachedState::$cachedConfig) &&
-            isset($this->traitsUsedByTest[WithCachedConfig::class])) {
+        if (isset(CachedState::$cachedConfig, $this->traitsUsedByTest[WithCachedConfig::class])) {
             $this->markConfigCached($app);
         }
 
-        if (isset(CachedState::$cachedRoutes) &&
-            isset($this->traitsUsedByTest[WithCachedRoutes::class])) {
+        if (isset(CachedState::$cachedRoutes, $this->traitsUsedByTest[WithCachedRoutes::class])) {
             $app->booting(fn () => $this->markRoutesCached($app));
         }
 

src/Illuminate/Http/Client/PendingRequest.php

@@ -1158,7 +1158,7 @@ protected function parseMultipartBodyFormat(array $data)
             ->flatMap(function ($value, $key) {
                 if (is_array($value)) {
                     // If the array has 'name' and 'contents' keys, it's already formatted for multipart...
-                    if (isset($value['name']) && isset($value['contents'])) {
+                    if (isset($value['name'], $value['contents'])) {
                         return [$value];
                     }
 

tests/Database/DatabaseEloquentModelTest.php

@@ -4165,8 +4165,7 @@ class EloquentModelBootingTestStub extends Model
 {
     public static function unboot()
     {
-        unset(static::$booted[static::class]);
-        unset(static::$bootedCallbacks[static::class]);
+        unset(static::$booted[static::class], static::$bootedCallbacks[static::class]);
     }
 
     public static function isBooted()
@@ -4756,8 +4755,7 @@ class EloquentModelBootingCallbackTestStub extends Model
 
     public static function unboot()
     {
-        unset(static::$booted[static::class]);
-        unset(static::$bootedCallbacks[static::class]);
+        unset(static::$booted[static::class], static::$bootedCallbacks[static::class]);
         static::$bootHasFinished = false;
     }
 }

tests/Foundation/FoundationApplicationBuilderTest.php

@@ -9,9 +9,7 @@ class FoundationApplicationBuilderTest extends TestCase
 {
     protected function tearDown(): void
     {
-        unset($_ENV['APP_BASE_PATH']);
-
-        unset($_ENV['LARAVEL_STORAGE_PATH'], $_SERVER['LARAVEL_STORAGE_PATH']);
+        unset($_ENV['APP_BASE_PATH'], $_ENV['LARAVEL_STORAGE_PATH'], $_SERVER['LARAVEL_STORAGE_PATH']);
 
         parent::tearDown();
     }

tests/Integration/Console/CommandEventsTest.php

@@ -42,8 +42,7 @@ protected function setUp(): void
         $this->beforeApplicationDestroyed(function () {
             $this->files->delete($this->logfile);
 
-            unset($this->files);
-            unset($this->logfile);
+            unset($this->files, $this->logfile);
         });
 
         parent::setUp();

tests/Pipeline/PipelineTest.php

@@ -210,8 +210,7 @@ public function testThenMethodInputValue()
         $this->assertSame('pipe::then::not_foo::', $result);
         $this->assertSame('::not_foo::', $_SERVER['__test.then.arg']);
 
-        unset($_SERVER['__test.then.arg']);
-        unset($_SERVER['__test.pipe.return']);
+        unset($_SERVER['__test.then.arg'], $_SERVER['__test.pipe.return']);
     }
 
     public function testPipelineUsageWithParameters()