Flip misordered assertions arguments (#59691)

Co-authored-by: Lucas Michot <lucas@zaiple.com>

Author: lucasmichot

tests/Config/RepositoryTest.php

@@ -52,7 +52,7 @@ protected function setUp(): void
     public function testGetValueWhenKeyContainDot()
     {
         $this->assertSame(
-            $this->repository->get('a.b'), 'c'
+            'c', $this->repository->get('a.b')
         );
         $this->assertNull(
             $this->repository->get('a.b.c')
@@ -308,7 +308,7 @@ public function testItThrowsAnExceptionWhenTryingToGetNonStringValueAsString():
     public function testItGetsAsArray(): void
     {
         $this->assertSame(
-            $this->repository->array('array'), ['aaa', 'zzz']
+            ['aaa', 'zzz'], $this->repository->array('array')
         );
     }
 
@@ -346,7 +346,7 @@ public function testItThrowsAnExceptionWhenTryingToGetNonBooleanValueAsBoolean()
     public function testItGetsAsInteger(): void
     {
         $this->assertSame(
-            $this->repository->integer('integer'), 1
+            1, $this->repository->integer('integer')
         );
     }
 
@@ -361,7 +361,7 @@ public function testItThrowsAnExceptionWhenTryingToGetNonIntegerValueAsInteger()
     public function testItGetsAsFloat(): void
     {
         $this->assertSame(
-            $this->repository->float('float'), 1.1
+            1.1, $this->repository->float('float')
         );
     }
 

tests/Container/ContainerResolveNonInstantiableTest.php

@@ -29,7 +29,7 @@ public function testResolveVariadicPrimitive()
         $container = new Container;
         $parent = $container->make(VariadicPrimitive::class);
 
-        $this->assertSame($parent->params, []);
+        $this->assertSame([], $parent->params);
     }
 }
 

tests/Database/DatabaseEloquentFactoryTest.php

@@ -628,15 +628,15 @@ public function test_sequence_with_has_many_relationship()
         $this->assertCount(6, FactoryTestPost::all());
         $this->assertCount(3, FactoryTestUser::latest()->first()->posts);
         $this->assertEquals(
-            FactoryTestPost::orderBy('title')->pluck('title')->all(),
             [
                 'Abigail Otwell Post 1',
                 'Abigail Otwell Post 2',
                 'Abigail Otwell Post 3',
                 'Taylor Otwell Post 1',
                 'Taylor Otwell Post 2',
                 'Taylor Otwell Post 3',
-            ]
+            ],
+            FactoryTestPost::orderBy('title')->pluck('title')->all()
         );
     }
 
@@ -999,8 +999,8 @@ public function test_can_default_to_without_parents()
 
     public function test_factory_model_names_correct()
     {
-        $this->assertEquals(FactoryTestUseFactoryAttribute::factory()->modelName(), FactoryTestUseFactoryAttribute::class);
-        $this->assertEquals(FactoryTestGuessModel::factory()->modelName(), FactoryTestGuessModel::class);
+        $this->assertEquals(FactoryTestUseFactoryAttribute::class, FactoryTestUseFactoryAttribute::factory()->modelName());
+        $this->assertEquals(FactoryTestGuessModel::class, FactoryTestGuessModel::factory()->modelName());
     }
 
     public function test_factory_global_model_resolver()
@@ -1009,11 +1009,11 @@ public function test_factory_global_model_resolver()
             return __NAMESPACE__.'\\'.Str::replaceLast('Factory', '', class_basename($factory::class));
         });
 
-        $this->assertEquals(FactoryTestGuessModel::factory()->modelName(), FactoryTestGuessModel::class);
-        $this->assertEquals(FactoryTestUseFactoryAttribute::factory()->modelName(), FactoryTestUseFactoryAttribute::class);
+        $this->assertEquals(FactoryTestGuessModel::class, FactoryTestGuessModel::factory()->modelName());
+        $this->assertEquals(FactoryTestUseFactoryAttribute::class, FactoryTestUseFactoryAttribute::factory()->modelName());
 
-        $this->assertEquals(FactoryTestUseFactoryAttributeFactory::new()->modelName(), FactoryTestUseFactoryAttribute::class);
-        $this->assertEquals(FactoryTestGuessModelFactory::new()->modelName(), FactoryTestGuessModel::class);
+        $this->assertEquals(FactoryTestUseFactoryAttribute::class, FactoryTestUseFactoryAttributeFactory::new()->modelName());
+        $this->assertEquals(FactoryTestGuessModel::class, FactoryTestGuessModelFactory::new()->modelName());
     }
 
     public function test_factory_model_has_many_relationship_has_pending_attributes()

tests/Database/DatabaseEloquentHasManyThroughIntegrationTest.php

@@ -132,7 +132,7 @@ public function testWithWhereHasOnARelationWithCustomIntermediateAndLocalKey()
 
         $this->assertCount(1, $country);
         $this->assertTrue($country->first()->relationLoaded('posts'));
-        $this->assertEquals($country->first()->posts->pluck('title')->unique()->toArray(), ['A title']);
+        $this->assertEquals(['A title'], $country->first()->posts->pluck('title')->unique()->toArray());
     }
 
     public function testFindMethod()

tests/Database/DatabaseEloquentHasOneThroughIntegrationTest.php

@@ -127,7 +127,7 @@ public function testWithWhereHasOnARelationWithCustomIntermediateAndLocalKey()
 
         $this->assertCount(1, $position);
         $this->assertTrue($position->first()->relationLoaded('contract'));
-        $this->assertEquals($position->first()->contract->pluck('title')->unique()->toArray(), ['A title']);
+        $this->assertEquals(['A title'], $position->first()->contract->pluck('title')->unique()->toArray());
     }
 
     public function testFirstOrFailThrowsAnException()

tests/Database/DatabaseEloquentIntegrationTest.php

@@ -1205,7 +1205,7 @@ public function testWithWhereHasOnSelfReferencingBelongsToManyRelationship()
         $this->assertCount(1, $results);
         $this->assertSame('taylorotwell@gmail.com', $results->first()->email);
         $this->assertTrue($results->first()->relationLoaded('friends'));
-        $this->assertSame($results->first()->friends->pluck('email')->unique()->toArray(), ['abigailotwell@gmail.com']);
+        $this->assertSame(['abigailotwell@gmail.com'], $results->first()->friends->pluck('email')->unique()->toArray());
     }
 
     public function testHasOnNestedSelfReferencingBelongsToManyRelationship()
@@ -1247,8 +1247,8 @@ public function testWithWhereHasOnNestedSelfReferencingBelongsToManyRelationship
         $this->assertCount(1, $results);
         $this->assertSame('taylorotwell@gmail.com', $results->first()->email);
         $this->assertTrue($results->first()->relationLoaded('friends'));
-        $this->assertSame($results->first()->friends->pluck('email')->unique()->toArray(), ['abigailotwell@gmail.com']);
-        $this->assertSame($results->first()->friends->pluck('friends')->flatten()->pluck('email')->unique()->toArray(), ['foo@gmail.com']);
+        $this->assertSame(['abigailotwell@gmail.com'], $results->first()->friends->pluck('email')->unique()->toArray());
+        $this->assertSame(['foo@gmail.com'], $results->first()->friends->pluck('friends')->flatten()->pluck('email')->unique()->toArray());
     }
 
     public function testHasOnSelfReferencingBelongsToManyRelationshipWithWherePivot()
@@ -1321,7 +1321,7 @@ public function testWithWhereHasOnSelfReferencingBelongsToRelationship()
         $this->assertCount(1, $results);
         $this->assertSame('Child Post', $results->first()->name);
         $this->assertTrue($results->first()->relationLoaded('parentPost'));
-        $this->assertSame($results->first()->parentPost->name, 'Parent Post');
+        $this->assertSame('Parent Post', $results->first()->parentPost->name);
     }
 
     public function testHasOnNestedSelfReferencingBelongsToRelationship()
@@ -1363,9 +1363,9 @@ public function testWithWhereHasOnNestedSelfReferencingBelongsToRelationship()
         $this->assertCount(1, $results);
         $this->assertSame('Child Post', $results->first()->name);
         $this->assertTrue($results->first()->relationLoaded('parentPost'));
-        $this->assertSame($results->first()->parentPost->name, 'Parent Post');
+        $this->assertSame('Parent Post', $results->first()->parentPost->name);
         $this->assertTrue($results->first()->parentPost->relationLoaded('parentPost'));
-        $this->assertSame($results->first()->parentPost->parentPost->name, 'Grandparent Post');
+        $this->assertSame('Grandparent Post', $results->first()->parentPost->parentPost->name);
     }
 
     public function testHasOnSelfReferencingHasManyRelationship()
@@ -1404,7 +1404,7 @@ public function testWithWhereHasOnSelfReferencingHasManyRelationship()
         $this->assertCount(1, $results);
         $this->assertSame('Parent Post', $results->first()->name);
         $this->assertTrue($results->first()->relationLoaded('childPosts'));
-        $this->assertSame($results->first()->childPosts->pluck('name')->unique()->toArray(), ['Child Post']);
+        $this->assertSame(['Child Post'], $results->first()->childPosts->pluck('name')->unique()->toArray());
     }
 
     public function testHasOnNestedSelfReferencingHasManyRelationship()
@@ -1446,8 +1446,8 @@ public function testWithWhereHasOnNestedSelfReferencingHasManyRelationship()
         $this->assertCount(1, $results);
         $this->assertSame('Grandparent Post', $results->first()->name);
         $this->assertTrue($results->first()->relationLoaded('childPosts'));
-        $this->assertSame($results->first()->childPosts->pluck('name')->unique()->toArray(), ['Parent Post']);
-        $this->assertSame($results->first()->childPosts->pluck('childPosts')->flatten()->pluck('name')->unique()->toArray(), ['Child Post']);
+        $this->assertSame(['Parent Post'], $results->first()->childPosts->pluck('name')->unique()->toArray());
+        $this->assertSame(['Child Post'], $results->first()->childPosts->pluck('childPosts')->flatten()->pluck('name')->unique()->toArray());
     }
 
     public function testHasWithNonWhereBindings()

tests/Database/DatabaseEloquentModelTest.php

@@ -3138,8 +3138,8 @@ public function testMergeCastsMergesCastsUsingArrays()
 
         $this->assertCount($castCount + 2, $model->getCasts());
         $this->assertArrayHasKey('foo', $model->getCasts());
-        $this->assertEquals($model->getCasts()['foo'], 'MyClass:myArgumentA');
-        $this->assertEquals($model->getCasts()['bar'], 'MyClass:myArgumentA,myArgumentB');
+        $this->assertEquals('MyClass:myArgumentA', $model->getCasts()['foo']);
+        $this->assertEquals('MyClass:myArgumentA,myArgumentB', $model->getCasts()['bar']);
     }
 
     public function testUnsetCastAttributes()

tests/Database/DatabaseMigrationCreatorTest.php

@@ -47,7 +47,7 @@ public function testBasicCreateMethodCallsPostCreateHooks()
         $creator->create('create_bar', 'foo', $table);
 
         $this->assertEquals($_SERVER['__migration.creator.table'], $table);
-        $this->assertEquals($_SERVER['__migration.creator.path'], 'foo/foo_create_bar.php');
+        $this->assertEquals('foo/foo_create_bar.php', $_SERVER['__migration.creator.path']);
 
         unset($_SERVER['__migration.creator.table'], $_SERVER['__migration.creator.path']);
     }

tests/Filesystem/FilesystemAdapterTest.php

@@ -677,7 +677,7 @@ public function testGetAllFiles()
 
         $filesystemAdapter = new FilesystemAdapter($this->filesystem, $this->adapter);
 
-        $this->assertSame($filesystemAdapter->files(), ['body.txt', 'existing.txt', 'file.txt', 'file1.txt']);
+        $this->assertSame(['body.txt', 'existing.txt', 'file.txt', 'file1.txt'], $filesystemAdapter->files());
     }
 
     public function testProvidesTemporaryUrls()

tests/Filesystem/FilesystemManagerTest.php

@@ -209,7 +209,7 @@ public function testCanBuildInlineScopedDisks()
 
             $scoped->put('dirname/filename.txt', 'file content');
             $this->assertTrue(is_dir(__DIR__.'/../../to-be-scoped/path-prefix'));
-            $this->assertEquals(file_get_contents(__DIR__.'/../../to-be-scoped/path-prefix/dirname/filename.txt'), 'file content');
+            $this->assertEquals('file content', file_get_contents(__DIR__.'/../../to-be-scoped/path-prefix/dirname/filename.txt'));
         } finally {
             unlink(__DIR__.'/../../to-be-scoped/path-prefix/dirname/filename.txt');
             rmdir(__DIR__.'/../../to-be-scoped/path-prefix/dirname');