Merge pull request #1380 from lem-project/rewrite-defcommand-argument

Replace arg-descriptor in defcommand with keyword

Author: cxxxr

contrib/google-translate/main.lisp

@@ -3,7 +3,7 @@
 ;;;don't edit above
 (defvar lem-user::*google-api-key* nil)
 
-(define-command popup-google-translate (start end) ("r")
+(define-command popup-google-translate (start end) (:region)
   (display-popup-message 
    (translate-client:translate 
     (points-to-string start end)

contrib/ollama/ollama.lisp

@@ -69,7 +69,7 @@
   (ignore-errors (bt2:join-thread *handler*))
   (when close-hook (funcall close-hook)))
 
-(define-command ollama-prompt (prompt) ("sPrompt: ")
+(define-command ollama-prompt (prompt) ((:string "Prompt: "))
   "prompt ollama, and stream the response to a temp buffer"
   (let ((buf (make-buffer "*ollama*" :temporary t)))
     (unless (eq (buffer-major-mode buf) 'ollama-mode)

contrib/selection-mode/selection-mode.lisp

@@ -61,21 +61,21 @@
 
 (defclass selection-advice () ())
 
-(define-command (selection-next-line (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-next-line (:advice-classes selection-advice)) (&optional n) (:universal)
   (call-with-selection #'next-line n))
-(define-command (selection-backward-char (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-backward-char (:advice-classes selection-advice)) (&optional n) (:universal)
   (call-with-selection #'backward-char n))
-(define-command (selection-forward-char (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-forward-char (:advice-classes selection-advice)) (&optional n) (:universal)
   (call-with-selection #'forward-char n))
-(define-command (selection-previous-line (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-previous-line (:advice-classes selection-advice)) (&optional n) (:universal)
   (call-with-selection #'previous-line n))
-(define-command (selection-copy (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-copy (:advice-classes selection-advice)) (&optional n) (:universal)
   (declare (ignore n))
   (message "Copy")
   (copy-to-clipboard (points-to-string (overlay-start *overlay*) (overlay-end *overlay*)))
   (cancel-selection))
 
-(define-command (selection-cut (:advice-classes selection-advice)) (&optional n) ("p")
+(define-command (selection-cut (:advice-classes selection-advice)) (&optional n) (:universal)
   (declare (ignore n))
   (message "Cut")
   (copy-to-clipboard (points-to-string (overlay-start *overlay*) (overlay-end *overlay*)))
@@ -84,7 +84,7 @@
   (cancel-selection))
 
 (define-command (selection-paste (:advice-classes selection-advice))
-    (&optional n) ("p")
+    (&optional n) (:universal)
   (declare (ignore n))
   (message "Paste")
   (paste-from-clipboard))

extensions/dart-mode/dart-mode.lisp

@@ -182,7 +182,7 @@ see : https://dart.dev/guides/language/language-tour
 
 ;; (define-key *dart-mode-keymap* "Tab" 'dart-insert-indent)
 
-(define-command dart-insert-indent (n) ("p")
+(define-command dart-insert-indent (n) (:universal)
   (with-point ((point (current-point)))
     (back-to-indentation point)
     (when (point< (current-point) point)

extensions/elisp-mode/run-elisp.lisp

@@ -75,7 +75,7 @@
                                    :name "run-elisp"
                                    :output-callback 'output-callback))))
 
-(define-command elisp-eval-region (start end) ("r")
+(define-command elisp-eval-region (start end) (:region)
   (unless (alive-process-p)
     (editor-error "Emacs Lisp Terminal process doesn't exist."))
   (lem-process:process-send-input *process* 

extensions/elixir-mode/run-elixir.lisp

@@ -72,7 +72,7 @@
                                    :name "run-elixir"
                                    :output-callback 'output-callback))))
 
-(define-command elixir-eval-region (start end) ("r")
+(define-command elixir-eval-region (start end) (:region)
   (unless (alive-process-p)
     (editor-error "elixir process doesn't exist."))
   (lem-process:process-send-input *process* (points-to-string start end)))

extensions/erlang-mode/run-erlang.lisp

@@ -73,7 +73,7 @@
                                    :name "run-erlang"
                                    :output-callback 'output-callback))))
 
-(define-command erlang-eval-region (start end) ("r")
+(define-command erlang-eval-region (start end) (:region)
   (unless (alive-process-p)
     (editor-error "Erlang process doesn't exist."))
   (lem-process:process-send-input *process* (points-to-string start end)))

extensions/go-mode/go-mode.lisp

@@ -138,7 +138,7 @@
                  (decf indent tab-width)))
              indent)))))
 
-(define-command go-electric-close (n) ("p")
+(define-command go-electric-close (n) (:universal)
   (self-insert n)
   (indent))
 

extensions/lisp-mode/apropos-mode.lisp

@@ -48,7 +48,7 @@
                 (or package
                     (current-package))))
 
-(define-command lisp-apropos (&optional arg) ("P")
+(define-command lisp-apropos (&optional arg) (:universal-nil)
   (check-connection)
   (let ((string)
         (only-external-p t)
@@ -70,7 +70,7 @@
   (lisp-apropos-internal (prompt-for-string "lisp Apropos: ")
                          nil nil nil))
 
-(define-command lisp-apropos-package (internal) ("P")
+(define-command lisp-apropos-package (internal) (:universal-nil)
   (check-connection)
   (let ((package (read-package-name)))
     (lisp-apropos-internal ""

extensions/lisp-mode/eval.lisp

@@ -233,7 +233,7 @@
       (eval-print string)
       (move-point (current-point) end))))
 
-(define-command lisp-eval-region (start end) ("r")
+(define-command lisp-eval-region (start end) (:region)
   "Execute the region as Lisp code."
   (check-connection)
   (eval-with-transcript