Add novendor build flag to use system installed libbpf#18
Merged
Conversation
Member
Author
Test planWith this docker container: Running: |
alexforster
reviewed
May 10, 2021
|
|
||
| if cfg!(feature = "novendor") { | ||
| let libbpf = pkg_config::Config::new() | ||
| .atleast_version("0.3.0") |
Member
There was a problem hiding this comment.
Concerned this will get out of sync with the crate version – I'll certainly forget to bump it! Can we instead do something like–
.atleast_version(&format!("{}.{}.{}", env!("CARGO_PKG_VERSION_MAJOR"), env!("CARGO_PKG_VERSION_MINOR"), env!("CARGO_PKG_VERSION_PATCH")))Since I guarantee that the major/minor/rev numbers will match the libbpf version exactly, I think this should Just Work™.
This commit adds support to build libbpf-sys using the system installed libbpf instead of building and linking against the vendored sources. This is necessary to get libbpf-sys packaged into (most) distro's package repositories. For example, Fedora has this requirement: https://fedoraproject.org/wiki/Bundled_Libraries
Member
|
Looks good. Once Travis runs I'll merge and cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support to build libbpf-sys using the system installed
libbpf instead of building and linking against the vendored sources.
This is necessary to get libbpf-sys packaged into (most) distro's
package repositories. For example, Fedora has this requirement:
https://fedoraproject.org/wiki/Bundled_Libraries
This closes #10 .