Update git_remote_rename to reflect new libgit2 signature

Author: Edward Thomson

LibGit2Sharp.Tests/RemoteFixture.cs

@@ -259,14 +259,14 @@ public void CanRenameExistingRemote()
         }
 
         [Fact]
-        public void CanRenameNonExistingRemote()
+        public void RenamingNonExistingRemoteThrows()
         {
             using (var repo = new Repository(StandardTestRepoPath))
             {
-                Assert.Null(repo.Network.Remotes["i_dont_exist"]);
-
-                repo.Network.Remotes.Rename("i_dont_exist", "i_dont_either", problem => Assert.True(false));
-                Assert.Null(repo.Network.Remotes["i_dont_either"]);
+                Assert.Throws<NotFoundException>(() =>
+                {
+                    repo.Network.Remotes.Rename("i_dont_exist", "i_dont_either");
+                });
             }
         }
 

LibGit2Sharp/Core/NativeMethods.cs

@@ -215,7 +215,8 @@ internal static extern int git_branch_remote_name(
         [DllImport(libgit2)]
         internal static extern int git_remote_rename(
             ref GitStrArray problems,
-            RemoteSafeHandle remote,
+            RepositorySafeHandle repo,
+            [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string old_name,
             [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string new_name);
 
         internal delegate int git_remote_rename_problem_cb(

LibGit2Sharp/Core/Proxy.cs

@@ -2125,39 +2125,38 @@ public static void git_remote_rename(RepositorySafeHandle repo, string name, str
         {
             using (ThreadAffinity())
             {
-                using (RemoteSafeHandle remote = git_remote_load(repo, name, false))
+                if (callback == null)
                 {
-                    if (remote == null)
-                    {
-                        return;
-                    }
+                    callback = problem => {};
+                }
 
-                    if (callback == null)
-                    {
-                        callback = problem => {};
-                    }
+                var array = new GitStrArrayNative();
 
-                    var array = new GitStrArrayNative();
+                try
+                {
+                    int res = NativeMethods.git_remote_rename(
+                        ref array.Array,
+                        repo,
+                        name,
+                        new_name);
 
-                    try
+                    if (res == (int)GitErrorCode.NotFound)
                     {
-                        int res = NativeMethods.git_remote_rename(
-                            ref array.Array,
-                            remote,
-                            new_name);
+                        throw new NotFoundException(
+                            string.Format("Remote '{0}' does not exist and cannot be renamed.", name));
+                    }
 
-                        Ensure.ZeroResult(res);
+                    Ensure.ZeroResult(res);
 
-                        foreach (var item in array.ReadStrings())
-                        {
-                            callback(item);
-                        }
-                    }
-                    finally
+                    foreach (var item in array.ReadStrings())
                     {
-                        array.Dispose();
+                        callback(item);
                     }
                 }
+                finally
+                {
+                    array.Dispose();
+                }
             }
         }