-
Notifications
You must be signed in to change notification settings - Fork 1.3k
websocket: record X-Real-IP header #1437
Copy link
Copy link
Open
Labels
exp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importantgood first issueGood issue for new contributorsGood issue for new contributorshelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing feature
Description
Metadata
Metadata
Assignees
Labels
exp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importantgood first issueGood issue for new contributorsGood issue for new contributorshelp wantedSeeking public contribution on this issueSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing feature
We currently don't support TLS here, so a reverse proxy needs to be set up, which has the side effect of loosing real ip addresses in
ipfs swarm peers.We could check if the
X-Real-IPheader is set when accepting connections and change the ip address we report as the remote (and probably only do that when we proxy from localhost)