fix: set correct workload values on first load#455
Merged
Merged
Conversation
ElderMatt
reviewed
Nov 11, 2024
Contributor
|
I can confirm this fix also works for APL-365. |
merll
approved these changes
Nov 11, 2024
ElderMatt
approved these changes
Nov 11, 2024
CasLubbers
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit 901a979.
j-zimnowoda
pushed a commit
that referenced
this pull request
Nov 11, 2024
* fix: set correct workload values on first load * fix: review comments (cherry picked from commit 901a979)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the setworkloadvalues down to the code editor so that it can set the values properly on first load.
The initial problem was that the workloadvalues now were set as a string resulting in an error when you made no changes.