Skip to content

fix: improve error handling#527

Merged
j-zimnowoda merged 5 commits into
mainfrom
APL-651
Apr 4, 2025
Merged

fix: improve error handling#527
j-zimnowoda merged 5 commits into
mainfrom
APL-651

Conversation

@ferruhcihan
Copy link
Copy Markdown
Collaborator

@ferruhcihan ferruhcihan commented Mar 14, 2025

Implement

https://jira.linode.com/browse/APL-651

Description

This PR updates error handling for JWT errors.
Is paired with: linode/apl-api#681

Screenshots

Please check the ticket attachments.

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Comment thread src/components/Error.tsx
@dennisvankekem
Copy link
Copy Markdown
Collaborator

dennisvankekem commented Mar 18, 2025

When I get an error page and I navigate to another page I still get the error page because the Error state doesn't get reset. Can you fix that? Because now you need to either click the back button or refresh, otherwise the error does not go away

@ElderMatt ElderMatt self-assigned this Mar 20, 2025
@dennisvankekem dennisvankekem self-assigned this Mar 20, 2025
Copy link
Copy Markdown
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error page works for me ✅

@ferruhcihan
Copy link
Copy Markdown
Collaborator Author

When I get an error page and I navigate to another page I still get the error page because the Error state doesn't get reset. Can you fix that? Because now you need to either click the back button or refresh, otherwise the error does not go away

We’re able to reset some of the error states within the paper layout or the error component itself. However, if the error comes from external sources (api, global state or RTK queries) it’s more difficult to reset those automatically since they're managed outside of the layout.

That’s why we’ve added a back button, so users can safely navigate away and reinitiate the process when needed.

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) April 4, 2025 13:47
@j-zimnowoda j-zimnowoda merged commit eb68c56 into main Apr 4, 2025
@j-zimnowoda j-zimnowoda deleted the APL-651 branch April 4, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants