feat: static team settings page #531
Merged
Merged
Conversation
dennisvankekem
commented
Mar 21, 2025
Collaborator
Author
|
note to self: fix light mode |
Collaborator
Author
|
Ready for first pass test and review, note that some logs and type: any might be floating around still. |
dennisvankekem
commented
Apr 2, 2025
Contributor
Contributor
Contributor
Contributor
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
|
The proposed resourceQuota is not compatible.
To reflect this:
|
dennisvankekem
commented
Apr 15, 2025
There was a problem hiding this comment.
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- public/i18n/en/common.json: Language not supported
Comments suppressed due to low confidence (2)
src/components/forms/TextField.tsx:335
- Using 'cleanedValue || ""' may inadvertently convert valid numeric inputs like 0 to an empty string. Consider an explicit check (e.g., checking 'cleanedValue' for null or undefined) to preserve 0 as a valid value.
setValue(cleanedValue || '')
src/components/KeyValue.tsx:186
- The TextField for the key is being assigned a static prop 'keyValue', which may override the form state managed by react-hook-form. Consider removing this prop or sourcing the value from the form state to ensure proper updates.
value={keyValue}
ferruhcihan
requested changes
Apr 16, 2025
Co-authored-by: Ferruh <63190600+ferruhcihan@users.noreply.github.com>
ferruhcihan
approved these changes
Apr 16, 2025
Contributor
Contributor
Contributor
Contributor
Contributor
ElderMatt
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.















PRs:
console: #531
api: linode/apl-api#672
core: linode/apl-core#2024
Considerations