Skip to content

fix: team UI rework#547

Merged
dennisvankekem merged 9 commits into
mainfrom
APL-735
Apr 25, 2025
Merged

fix: team UI rework#547
dennisvankekem merged 9 commits into
mainfrom
APL-735

Conversation

@dennisvankekem
Copy link
Copy Markdown
Collaborator

@dennisvankekem dennisvankekem commented Apr 24, 2025

This is a first batch of fixes as seen in the team journal https://docs.google.com/document/d/17YphieF61uyGtSFgIg8k_u2FMWqlPnq-LbaYPVn0Dec/edit?tab=t.0

Consists of:

  • Added missing network policies
  • fixed the bug that removed disabled fields in Resource Quota causing weird behaviour if you removed the compute resource quota keys
  • changed 'edit teams' to 'save changes' this change is backported to other pages
  • When you go to team settings as a team member you don't see alerts that are designated for admins
  • team name cannot exceed more than 30 characters
  • resourceQuota's for team increased to 24 CPU and 32Gi memory
  • All permissions are enabled by default when creating a new team

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem dennisvankekem requested a review from Copilot April 24, 2025 11:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reworks the team UI to fix issues with resource quotas, permissions defaults, and button labels while also adding missing network policies. Key changes include updated conditional logic for displaying sections based on admin status, changes to team and resource quota validation rules, and UI text updates across team, code repositories, and builds pages.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/pages/teams/create-edit/index.tsx Updates conditional display for sections and fixes a typo in the button label.
src/pages/teams/create-edit/create-edit-teams.validator.ts Adjusts team name length and permission defaults and updates resource quota values.
src/pages/teams/create-edit/ResourceQuotaKeyValue.tsx Updates compute resource quota labels and decorator mappings.
src/pages/code-repositories/create-edit/index.tsx Changes button text from "Edit Code Repository" to "Save Changes".
src/pages/builds/create-edit/index.tsx Changes button text from "Edit Container Image" to "Save Changes".
src/components/KeyValue.tsx Removes duplicate registration calls in TextField components.

Comment thread src/pages/teams/create-edit/index.tsx Outdated
Comment thread src/pages/teams/create-edit/index.tsx Outdated
Comment thread src/pages/teams/create-edit/index.tsx Outdated
Comment thread src/pages/teams/create-edit/create-edit-teams.validator.ts Outdated
@dennisvankekem dennisvankekem merged commit 40e2c48 into main Apr 25, 2025
2 checks passed
@dennisvankekem dennisvankekem deleted the APL-735 branch April 25, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants