fix: team UI rework#547
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the team UI to fix issues with resource quotas, permissions defaults, and button labels while also adding missing network policies. Key changes include updated conditional logic for displaying sections based on admin status, changes to team and resource quota validation rules, and UI text updates across team, code repositories, and builds pages.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/teams/create-edit/index.tsx | Updates conditional display for sections and fixes a typo in the button label. |
| src/pages/teams/create-edit/create-edit-teams.validator.ts | Adjusts team name length and permission defaults and updates resource quota values. |
| src/pages/teams/create-edit/ResourceQuotaKeyValue.tsx | Updates compute resource quota labels and decorator mappings. |
| src/pages/code-repositories/create-edit/index.tsx | Changes button text from "Edit Code Repository" to "Save Changes". |
| src/pages/builds/create-edit/index.tsx | Changes button text from "Edit Container Image" to "Save Changes". |
| src/components/KeyValue.tsx | Removes duplicate registration calls in TextField components. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
j-zimnowoda
reviewed
Apr 24, 2025
j-zimnowoda
reviewed
Apr 24, 2025
ElderMatt
approved these changes
Apr 25, 2025
j-zimnowoda
reviewed
Apr 25, 2025
j-zimnowoda
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first batch of fixes as seen in the team journal https://docs.google.com/document/d/17YphieF61uyGtSFgIg8k_u2FMWqlPnq-LbaYPVn0Dec/edit?tab=t.0
Consists of:
Considerations