feat: [APL-898] - Network Policies Page

[dennisvankekem]

Considerations

• I have tested the changes in both light and dark mode.
• I have considered the need for new unit tests.
• I have tested the changes on a cluster.
• I have included relevant documentation updates.
• I have an approved Figma design or have reflected my changes in Figma
• I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
• I have tested the changes for responsiveness in different screen resolutions.
• I have tested expected error states and verified that the user is presented with informative error messages.
• I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

[ElderMatt]

Deployed on cluster and without having any services or workloads I see the following for both outbound and inbound rules.

[ElderMatt]

Should it be allowed to target the same source?

[ElderMatt]

Why is the first source allowed to be removed? It would be nice if the remove button only shows up for the sources if there is more than 1.

[ElderMatt]

I dont get an error when trying to create a rule and not having a source.

[ElderMatt]

Error handling is also missing for the Inbound rule name and workload target

[ElderMatt]

Im am unable to have inbound and outbound rule with the same name, I get why but it looks weird because they are in separate tables. I think we should change the error so that it is clear that inbound and outbound rules cannot have the same name.

[dennisvankekem]

Should it be allowed to target the same source?

Strangly enough, yes.

[ferruhcihan]

Reviewed and tested with a cluster. I was able to create inbound and outbound rules successfully, and they worked as expected.

However, some pages and components need adjustments:

• Inbound Rules: When I search and select the label of the target, : turns into =.
• Inbound Rules: When I click an existing inbound rule or reload the page, I lose my actual labels and they default to the first items in their lists.
• Outbound Rules: When I try to update an existing outbound rule, I can enter invalid port numbers and still submit the form. No error message is shown. It doesn’t affect the actual value in the values repository, but it's confusing.
• There are some unresolved issues.

Screenshots:

[ElderMatt]

At the moment on the overview page I am missing certain columns, in the design we had for inbound (name, source, target) and for outbound we had (name, port ,protocol). At the moment we have rule type which makes no sense because they are already split between inbound and outbound.

[ElderMatt]

Reviewed and tested with a cluster. I was able to create inbound and outbound rules successfully, and they worked as expected.

However, some pages and components need adjustments:

• Inbound Rules: When I search and select the label of the target, : turns into =.
• Inbound Rules: When I click an existing inbound rule or reload the page, I lose my actual labels and they default to the first items in their lists.
• Outbound Rules: When I try to update an existing outbound rule, I can enter invalid port numbers and still submit the form. No error message is shown. It doesn’t affect the actual value in the values repository, but it's confusing.
• There are some unresolved issues.

Screenshots:

Can confirm that these are still there.

[ElderMatt]

I am not able to submit, but also dont see an error.

[ElderMatt]

Can you remove the graph and put it in a separate branch?