DPS-34824 update after changes - Region field removed and delete confirmation modal added

Author: kagora-akamai

packages/manager/cypress/e2e/core/delivery/create-destination.spec.ts

@@ -11,7 +11,7 @@ import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
 import { ui } from 'support/ui';
 import { logsDestinationForm } from 'support/ui/pages/logs-destination-form';
 
-import type { LinodeObjectStorageDetails } from '@linode/api-v4';
+import type { AkamaiObjectStorageDetails } from '@linode/api-v4';
 
 describe('Create Destination', () => {
   before(() => {
@@ -27,7 +27,7 @@ describe('Create Destination', () => {
     logsDestinationForm.setLabel(mockDestinationPayload.label);
 
     logsDestinationForm.fillDestinationDetailsForm(
-      mockDestinationPayload.details as LinodeObjectStorageDetails
+      mockDestinationPayload.details as AkamaiObjectStorageDetails
     );
 
     // Create Destination should be disabled before test connection

packages/manager/cypress/e2e/core/delivery/destinations-non-empty-landing-page.spec.ts

@@ -54,7 +54,17 @@ function deleteItem(tableAlias: string, destination: Destination) {
 
       // Delete destination
       ui.actionMenuItem.findByTitle('Delete').click();
+
+      // Find confirmation modal
+      cy.findByText(
+        `Are you sure you want to delete "${destination.label}" destination?`
+      );
+      ui.button.findByTitle('Delete').click();
+
       cy.wait('@deleteDestination');
+
+      // Close confirmation modal after failure
+      ui.button.findByTitle('Cancel').click();
     });
 }
 

packages/manager/cypress/e2e/core/delivery/edit-destination.spec.ts

@@ -15,7 +15,7 @@ import { randomLabel } from 'support/util/random';
 
 import { getDestinationTypeOption } from 'src/features/Delivery/deliveryUtils';
 
-import type { LinodeObjectStorageDetails } from '@linode/api-v4';
+import type { AkamaiObjectStorageDetails } from '@linode/api-v4';
 
 describe('Edit Destination', () => {
   beforeEach(() => {
@@ -39,7 +39,7 @@ describe('Edit Destination', () => {
 
   it('edit destination with incorrect data', () => {
     logsDestinationForm.fillDestinationDetailsForm(
-      mockDestinationPayload.details as LinodeObjectStorageDetails
+      mockDestinationPayload.details as AkamaiObjectStorageDetails
     );
 
     // Create Destination should be disabled before test connection
@@ -66,7 +66,7 @@ describe('Edit Destination', () => {
     logsDestinationForm.setLabel(newLabel);
 
     logsDestinationForm.fillDestinationDetailsForm(
-      mockDestinationPayload.details as LinodeObjectStorageDetails
+      mockDestinationPayload.details as AkamaiObjectStorageDetails
     );
 
     // Create Destination should be disabled before test connection

packages/manager/cypress/support/constants/delivery.ts

@@ -14,7 +14,7 @@ export const regions = [
 
 export const mockDestinationPayload = {
   label: randomLabel(),
-  type: destinationType.LinodeObjectStorage,
+  type: destinationType.AkamaiObjectStorage,
   details: {
     host: randomString(),
     bucket_name: randomString(),

packages/manager/cypress/support/ui/pages/logs-destination-form.ts

@@ -1,12 +1,10 @@
-import { regions } from 'support/constants/delivery';
 /**
  * @file Page utilities for Logs Delivery Destination Form.
  * Create/Edit Destination Page
  * Create/Edit Stream Page
  */
-import { ui } from 'support/ui';
 
-import type { LinodeObjectStorageDetails } from '@linode/api-v4';
+import type { AkamaiObjectStorageDetails } from '@linode/api-v4';
 
 export const logsDestinationForm = {
   /**
@@ -51,26 +49,6 @@ export const logsDestinationForm = {
     cy.focused().type(bucketName);
   },
 
-  /**
-   * Selects destination's region
-   *
-   * @param region - region to select
-   */
-  selectRegion: (region: string) => {
-    // Find Region select and open it
-    cy.findByLabelText('Region')
-      .should('be.visible')
-      .should('be.enabled')
-      .should('have.attr', 'placeholder', 'Select a Region')
-      .clear();
-    // Select the Region
-    ui.autocompletePopper
-      .findByTitle(getRegionLabel(region))
-      .should('be.visible')
-      .should('be.enabled')
-      .click();
-  },
-
   /**
    * Sets destination's Access Key ID
    *
@@ -104,23 +82,17 @@ export const logsDestinationForm = {
    *
    * @param data - object with destination details of LinodeObjectStorageDetails type
    */
-  fillDestinationDetailsForm: (data: LinodeObjectStorageDetails) => {
+  fillDestinationDetailsForm: (data: AkamaiObjectStorageDetails) => {
     // Give Destination a host
     logsDestinationForm.setHost(data.host);
 
     // Give Destination a bucket
     logsDestinationForm.setBucket(data.bucket_name);
 
-    // Find Region select and open it
-    logsDestinationForm.selectRegion(data.region);
-
     // Give the Destination Access Key ID
     logsDestinationForm.setAccessKeyId(data.access_key_id);
 
     // Give the Destination Secret Access Key
     logsDestinationForm.setSecretAccessKey(data.access_key_secret);
   },
 };
-
-const getRegionLabel = (regionId: string): string =>
-  regions.find(({ id }) => id === regionId)?.label ?? '';