[workflows] Only run code formatter on the main branch#80348
Merged
Conversation
Further modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches.
Member
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesModifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. Full diff: https://github.com/llvm/llvm-project/pull/80348.diff 1 Files Affected:
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 5223089ee8a93..c8fd541fd34db 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -1,5 +1,8 @@
name: "Check code formatting"
on: pull_request_target
+ branches:
+ - main
+
permissions:
pull-requests: write
|
boomanaiden154
approved these changes
Feb 1, 2024
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM. Reasoning makes sense to me, but not really familiar with release best practices.
Contributor
Author
|
/cherry-pick 2193c95 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 4, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
Member
|
/pull-request #80585 |
agozillon
pushed a commit
to agozillon/llvm-project
that referenced
this pull request
Feb 5, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches.
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 6, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 6, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
tstellar
added a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
tstellar
added a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
tstellar
added a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
tstellar
added a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches.