[Profile][Windows] Drop extern for __buildid.

[ZequanWu]

No description provided.

[llvmbot]

@llvm/pr-subscribers-pgo

Author: Zequan Wu (ZequanWu)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/80700.diff

1 Files Affected:

• (modified) compiler-rt/lib/profile/InstrProfilingPlatformWindows.c (+1-1)

diff --git a/compiler-rt/lib/profile/InstrProfilingPlatformWindows.c b/compiler-rt/lib/profile/InstrProfilingPlatformWindows.c
index c976776ae59e9..0751b28f81d0a 100644
--- a/compiler-rt/lib/profile/InstrProfilingPlatformWindows.c
+++ b/compiler-rt/lib/profile/InstrProfilingPlatformWindows.c
@@ -77,7 +77,7 @@ ValueProfNode *EndVNode = &VNodesEnd;
 /* lld-link provides __buildid symbol which ponits to the 16 bytes build id when
  * using /build-id flag. https://lld.llvm.org/windows_support.html#lld-flags */
 #define BUILD_ID_LEN 16
-COMPILER_RT_WEAK extern uint8_t __buildid[BUILD_ID_LEN];
+COMPILER_RT_WEAK uint8_t __buildid[BUILD_ID_LEN];
 COMPILER_RT_VISIBILITY int __llvm_write_binary_ids(ProfDataWriter *Writer) {
   if (*__buildid) {
     if (Writer &&

[nikic]

LGTM, I confirmed that this fixes the mingw build.

[mati865]

Can we also backport it to 18 release?

also cc @mstorsjo for awareness

[mstorsjo]

Just for reference - see #75618 (comment) for a bit more discussion on the solution chosen here. (In short, the chosen solution is fine.)