fix: Don't overwrite base logging Handler class lock var #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkinsmezmo
force-pushed
the
usr/shawkins/fix-var-shadowing
branch
from
e390400 to
8f62f9a
Compare
dkhokhlov
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base
logging.Handlerclass has it's own instance variable namedself.lock. This variable is used to lock access to a given handler.The current variable naming was overriding this lock, leading to deadlocks that would occur when the logging framework would attempt to acquire the base handler lock for configuration purposes, which would then cause any attempts by the logdna handler to acquire this lock to block indefinitely.
This PR addresses this issue by renaming the internal lock variable, ensuring that it remains logically distinct as it was intended.