Fixes a few typechecking errors in lute (#806)

There is a type error in the std test library caused by the type of the
assertions table not being in the `asserts.luau` file anymore. This
caused a number of downstream type errors in test scripts, because they
were adding annotation for an assertions table that didn't exist in that
file.
Edit: also fixed an fs.luau tc error.

Author: Vighnesh-V

lute/std/libs/fs.luau

@@ -77,7 +77,7 @@ end
 --- Also provides a `close` method to stop watching.
 --- Note: for loops do not support yielding generalized iterators, so we cannot use fs.watch as `for _ in fs.watch(...) do` directly. A while loop can be used instead. See example/watch_directory.luau for usage.
 function fslib.watch(path: pathlike): watcher
-	local queue = {}
+	local queue: { { filename: pathlib.path, event: watchevent } } = {}
 	local handle = fs.watch(pathlib.format(path), function(filename: string, event: watchevent)
 		table.insert(queue, { filename = pathlib.parse(filename), event = event })
 	end)
@@ -88,6 +88,7 @@ function fslib.watch(path: pathlike): watcher
 				return nil
 			end
 			local item = table.remove(queue, 1)
+			assert(item)
 			return item.event
 		end,
 		close = function(_self: watcher): ()

lute/std/libs/test/reporter.luau

@@ -3,11 +3,9 @@
 -- Standard test reporter library for Luau
 
 local types = require("./types")
-local assert = require("./assert")
 
 type FailedTest = types.failedtest
 type TestRunResult = types.testrunresult
-type Assertions = assert.asserts
 
 local reporter = {}
 

tests/std/syntax/printer.test.luau

@@ -1,4 +1,4 @@
-local assertLib = require("@std/test/assert")
+local testtypes = require("@std/test/types")
 local printer = require("@std/syntax/printer")
 local query = require("@std/syntax/query")
 local syntax = require("@std/syntax")
@@ -10,7 +10,7 @@ local function checkReplacement(
 	source: string,
 	expected: string,
 	transformFn: (syntaxTypes.AstNode) -> syntaxTypes.replacements?,
-	assert: assertLib.asserts
+	assert: testtypes.asserts
 )
 	local ast = syntax.parse(source)
 	local replacements = transformFn(ast.root)

tests/std/test.test.luau

@@ -1,4 +1,4 @@
-local assertions = require("@std/test/assert")
+local testtypes = require("@std/test/types")
 local fs = require("@std/fs")
 local path = require("@std/path")
 local process = require("@std/process")
@@ -12,7 +12,7 @@ local function assertErrorsWithMsg(
 	testName: string,
 	testContents: string,
 	expectedErrMsg: string,
-	assert: assertions.asserts
+	assert: testtypes.asserts
 )
 	local testFilePath = path.join(tmpDir, `{testName}.test.luau`)
 	fs.writestringtofile(testFilePath, testContents)

tools/check-faillist.txt

@@ -105,20 +105,12 @@ lute/cli/commands/transform/lib/arguments.luau:47:26-37
 lute/cli/commands/transform/lib/arguments.luau:47:26-37
 lute/cli/commands/transform/lib/arguments.luau:75:9-14
 lute/cli/commands/transform/lib/arguments.luau:75:9-14
-lute/std/libs/fs.luau:82:3-14
-lute/std/libs/fs.luau:82:3-14
-lute/std/libs/fs.luau:90:17-28
-lute/std/libs/fs.luau:90:17-28
-lute/std/libs/fs.luau:91:11-20
-lute/std/libs/fs.luau:91:11-20
-lute/std/libs/fs.luau:91:11-20
-lute/std/libs/fs.luau:91:11-20
-lute/std/libs/fs.luau:135:34-39
-lute/std/libs/fs.luau:135:34-39
-lute/std/libs/fs.luau:184:52-68
-lute/std/libs/fs.luau:184:52-68
-lute/std/libs/fs.luau:192:11-17
-lute/std/libs/fs.luau:192:11-17
+lute/std/libs/fs.luau:136:34-39
+lute/std/libs/fs.luau:136:34-39
+lute/std/libs/fs.luau:185:52-68
+lute/std/libs/fs.luau:185:52-68
+lute/std/libs/fs.luau:193:11-17
+lute/std/libs/fs.luau:193:11-17
 lute/std/libs/syntax/printer.luau:41:23-27
 lute/std/libs/syntax/printer.luau:41:23-27
 lute/std/libs/syntax/printer.luau:42:25-29
@@ -213,8 +205,6 @@ lute/std/libs/syntax/visitor.luau:1074:22-25
 lute/std/libs/syntax/visitor.luau:1074:22-25
 lute/std/libs/test/failure.luau:18:35-38
 lute/std/libs/test/failure.luau:18:35-38
-lute/std/libs/test/reporter.luau:10:19-32
-lute/std/libs/test/reporter.luau:10:19-32
 tests/batteries/collections/deque.test.luau:9:13-16
 tests/batteries/collections/deque.test.luau:16:13-16
 tests/batteries/collections/deque.test.luau:24:13-16
@@ -270,68 +260,8 @@ tests/std/process.test.luau:123:41-42
 tests/std/process.test.luau:126:43-44
 tests/std/process.test.luau:130:41-53
 tests/std/process.test.luau:134:33-48
-tests/std/syntax/printer.test.luau:13:10-26
-tests/std/syntax/printer.test.luau:35:8-13
-tests/std/syntax/printer.test.luau:49:8-13
-tests/std/syntax/printer.test.luau:63:8-13
-tests/std/syntax/printer.test.luau:82:8-13
 tests/std/syntax/printer.test.luau:95:10-100
 tests/std/syntax/printer.test.luau:97:7-32
-tests/std/syntax/printer.test.luau:103:8-13
-tests/std/syntax/printer.test.luau:119:8-13
-tests/std/syntax/printer.test.luau:131:8-13
-tests/std/syntax/printer.test.luau:143:8-13
-tests/std/syntax/printer.test.luau:155:8-13
-tests/std/syntax/printer.test.luau:167:8-13
-tests/std/syntax/printer.test.luau:180:8-13
-tests/std/syntax/printer.test.luau:192:8-13
-tests/std/syntax/printer.test.luau:204:8-13
-tests/std/syntax/printer.test.luau:216:8-13
-tests/std/syntax/printer.test.luau:228:8-13
-tests/std/syntax/printer.test.luau:240:8-13
-tests/std/syntax/printer.test.luau:252:8-13
-tests/std/syntax/printer.test.luau:264:8-13
-tests/std/syntax/printer.test.luau:276:8-13
-tests/std/syntax/printer.test.luau:288:8-13
-tests/std/syntax/printer.test.luau:300:8-13
-tests/std/syntax/printer.test.luau:312:8-13
-tests/std/syntax/printer.test.luau:324:8-13
-tests/std/syntax/printer.test.luau:336:8-13
-tests/std/syntax/printer.test.luau:349:8-13
-tests/std/syntax/printer.test.luau:366:8-13
-tests/std/syntax/printer.test.luau:381:8-13
-tests/std/syntax/printer.test.luau:396:8-13
-tests/std/syntax/printer.test.luau:411:8-13
-tests/std/syntax/printer.test.luau:426:8-13
-tests/std/syntax/printer.test.luau:439:8-13
-tests/std/syntax/printer.test.luau:452:8-13
-tests/std/syntax/printer.test.luau:465:8-13
-tests/std/syntax/printer.test.luau:480:8-13
-tests/std/syntax/printer.test.luau:495:8-13
-tests/std/syntax/printer.test.luau:509:8-13
-tests/std/syntax/printer.test.luau:523:8-13
-tests/std/syntax/printer.test.luau:538:8-13
-tests/std/syntax/printer.test.luau:553:8-13
-tests/std/syntax/printer.test.luau:566:8-13
-tests/std/syntax/printer.test.luau:579:8-13
-tests/std/syntax/printer.test.luau:593:8-13
-tests/std/syntax/printer.test.luau:606:8-13
-tests/std/syntax/printer.test.luau:619:8-13
-tests/std/syntax/printer.test.luau:632:8-13
-tests/std/syntax/printer.test.luau:645:8-13
-tests/std/syntax/printer.test.luau:658:8-13
-tests/std/syntax/printer.test.luau:671:8-13
-tests/std/syntax/printer.test.luau:684:8-13
-tests/std/syntax/printer.test.luau:697:8-13
-tests/std/syntax/printer.test.luau:710:8-13
-tests/std/syntax/printer.test.luau:723:8-13
-tests/std/syntax/printer.test.luau:736:8-13
-tests/std/syntax/printer.test.luau:749:8-13
-tests/std/syntax/printer.test.luau:762:8-13
-tests/std/syntax/printer.test.luau:775:8-13
-tests/std/syntax/printer.test.luau:788:8-13
-tests/std/syntax/printer.test.luau:801:8-13
-tests/std/syntax/printer.test.luau:814:8-13
 tests/std/syntax/printer.test.luau:825:38-60
 tests/std/syntax/printer.test.luau:825:38-60
 tests/std/syntax/printer.test.luau:825:38-60
@@ -432,29 +362,12 @@ tests/std/syntax/printer.test.luau:825:38-60
 tests/std/syntax/printer.test.luau:825:38-60
 tests/std/syntax/printer.test.luau:825:38-60
 tests/std/syntax/printer.test.luau:825:38-60
-tests/std/syntax/printer.test.luau:828:8-13
-tests/std/syntax/printer.test.luau:849:8-13
 tests/std/syntax/printer.test.luau:877:23-31
-tests/std/syntax/printer.test.luau:884:8-13
 tests/std/syntax/query.test.luau:41:7-7
 tests/std/syntax/query.test.luau:41:7-7
 tests/std/tableext.test.luau:57:18-18
 tests/std/tableext.test.luau:62:18-18
 tests/std/tableext.test.luau:63:18-18
-tests/std/test.test.luau:15:10-27
-tests/std/test.test.luau:113:4-9
-tests/std/test.test.luau:132:4-9
-tests/std/test.test.luau:149:4-9
-tests/std/test.test.luau:168:4-9
-tests/std/test.test.luau:185:4-9
-tests/std/test.test.luau:204:4-9
-tests/std/test.test.luau:223:4-9
-tests/std/test.test.luau:246:4-9
-tests/std/test.test.luau:263:4-9
-tests/std/test.test.luau:282:4-9
-tests/std/test.test.luau:299:4-9
-tests/std/test.test.luau:318:4-9
-tests/std/test.test.luau:337:4-9
 tools/luthier.luau:158:2-26
 tools/luthier.luau:197:3-12
 tools/luthier.luau:198:11-25