Rename Storage::Base base class to Storage and add S3 shard

Author: wout

shard.yml

@@ -56,5 +56,8 @@ development_dependencies:
   ameba:
     github: crystal-ameba/ameba
     version: ~> 1.6.4
+  awscr-s3:
+    github: taylorfinnell/awscr-s3
+    version: ~> 0.10.0
 
 license: MIT

spec/lucky/attachment/uploader_spec.cr

@@ -94,7 +94,7 @@ describe Lucky::Attachment::Uploader do
     context "error handling" do
       it "raises Error when no storages are not configured" do
         Lucky::Attachment.configure do |settings|
-          settings.storages = {} of String => Lucky::Attachment::Storage::Base
+          settings.storages = {} of String => Lucky::Attachment::Storage
         end
 
         expect_raises(

src/lucky/attachment/config.cr

@@ -10,7 +10,7 @@ module Lucky::Attachment
     # NOTE: Additional stores are not supported yet. Please reach out if that
     # is something you need.
     #
-    setting storages : Hash(String, Storage::Base) = {} of String => Storage::Base
+    setting storages : Hash(String, Storage) = {} of String => Storage
 
     # Path prefix for uploads. Possible keywords are:
     # - `:model` (an underscored string of the model name)
@@ -27,7 +27,7 @@ module Lucky::Attachment
   # Lucky::Attachment.find_storage("missing") # raises Lucky::Attachment::Error
   # ```
   #
-  def self.find_storage(name : String) : Storage::Base
+  def self.find_storage(name : String) : Storage
     settings.storages[name]? ||
       raise Error.new(
         String.build do |io|

src/lucky/attachment/storage.cr

@@ -2,7 +2,7 @@
 # Implementations must provide methods for uploading, retreiving, checking
 # existence, and deleting files.
 #
-abstract class Lucky::Attachment::Storage::Base
+abstract class Lucky::Attachment::Storage
   # Uploads an IO to the given location (id) in the storage.
   #
   # ```

src/lucky/attachment/storage/file_system.cr

@@ -15,7 +15,7 @@ require "../storage"
 # end
 # ```
 #
-class Lucky::Attachment::Storage::FileSystem < Lucky::Attachment::Storage::Base
+class Lucky::Attachment::Storage::FileSystem < Lucky::Attachment::Storage
   DEFAULT_PERMISSIONS           = File::Permissions.new(0o644)
   DEFAULT_DIRECTORY_PERMISSIONS = File::Permissions.new(0o755)
 

src/lucky/attachment/storage/memory.cr

@@ -11,7 +11,7 @@ require "../storage"
 # end
 # ```
 #
-class Lucky::Attachment::Storage::Memory < Lucky::Attachment::Storage::Base
+class Lucky::Attachment::Storage::Memory < Lucky::Attachment::Storage
   getter store : Hash(String, Bytes)
   getter base_url : String?
 

src/lucky/attachment/stored_file.cr

@@ -110,7 +110,7 @@ class Lucky::Attachment::StoredFile
   end
 
   # Returns the storage instance this file is stored in.
-  def storage : Storage::Base
+  def storage : Storage
     ::Lucky::Attachment.find_storage(storage_key)
   end
 

src/lucky/attachment/uploader.cr

@@ -22,7 +22,7 @@ abstract struct Lucky::Attachment::Uploader
   end
 
   # Returns the storage instance for this uploader.
-  def storage : Storage::Base
+  def storage : Storage
     Lucky::Attachment.find_storage(storage_key)
   end