drafts: improve test files and support note links

Author: marph91

docs/formats/drafts.md

@@ -11,7 +11,7 @@ source_app: Drafts
 
 ## Instructions
 
-1. Creata a backup as described [at the website](https://docs.getdrafts.com/docs/settings/backups#partial-backups)
+1. Create a backup as described [at the website](https://docs.getdrafts.com/docs/settings/backups#partial-backups)
 2. [Install Jimmy](../index.md#installation)
 3. Convert to Markdown. Example: `jimmy-linux cli DraftsExport.draftsExport --format drafts`
 4. [Import to your app](../import_instructions.md)
@@ -20,8 +20,8 @@ source_app: Drafts
 
 | Feature | Supported? | Remark |
 | --- | :---: | --- |
-| Attachments / Images / Resources | ❎ | Please share an example file. |
+| Attachments / Images / Resources | ⬜ | |
 | Labels / Tags | ✅ | |
-| Note Links | ❎ | Please share an example file. |
+| Note Links | ✅ | |
 | Notebook / Folder Hierarchy | ✅ | |
 | Rich Text | ✅ | |

jimmy/formats/drafts.py

@@ -2,18 +2,67 @@
 
 import json
 from pathlib import Path
+import re
 
 from jimmy import common, converter, intermediate_format as imf
+import jimmy.md_lib.common
+
+
+DRAFTS_LINK_RE = re.compile(
+    r"(drafts:\/\/open\?uuid="
+    r"([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}))"
+)
 
 
 class Converter(converter.BaseConverter):
     accepted_extensions = [".draftsexport"]
 
-    @common.catch_all_exceptions
-    def convert_note(self, draft):
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+        self.note_id_title_map = {}
+
+    def handle_drafts_links(self, note_body: str) -> imf.NoteLinks:
+        """
+        Drafts links are raw text. Not wrapped in Markdown syntax.
+        https://docs.getdrafts.com/docs/drafts/cross-linking#draft-links-urls
+        """
+        note_links = []
+        for original_text, id_ in DRAFTS_LINK_RE.findall(note_body):
+            note_links.append(imf.NoteLink(original_text, id_, ""))
+        return note_links
+
+    def handle_wikilink_links(self, body: str) -> imf.NoteLinks:
+        # https://docs.getdrafts.com/docs/drafts/cross-linking#wiki-style-cross-linking-drafts
+        note_links = []
+        for _, url, _ in jimmy.md_lib.common.get_wikilink_links(body):
+            original_text = f"[[{url}]]"
+            if url.startswith("d:"):
+                best_match_id = common.get_best_match(url[2:], self.note_id_title_map)
+                if best_match_id is not None:
+                    note_links.append(imf.NoteLink(original_text, best_match_id, ""))
+            elif url.startswith("u:"):  # id
+                note_links.append(imf.NoteLink(original_text, url[2:], ""))
+            elif url.startswith("w:") or url.startswith("s:"):
+                pass  # TODO: How to handle workspaces and search?
+            else:  # no prefix
+                best_match_id = common.get_best_match(url, self.note_id_title_map)
+                if best_match_id is not None:
+                    note_links.append(imf.NoteLink(original_text, best_match_id, ""))
+        return note_links
+
+    @staticmethod
+    def get_title(content: str) -> str:
         # There is no title in drafts.
         # Simply take the first 80 characters of the first line.
-        title = draft["content"].partition("\n")[0][:80].strip()
+        if content.strip():
+            for line in content.split("\n"):
+                if line.strip():
+                    return line[:80].strip()
+        return common.unique_title()
+
+    @common.catch_all_exceptions
+    def convert_note(self, draft):
+        title = self.get_title(draft["content"])
         self.logger.debug(f'Converting draft "{title}"')
 
         if draft["languageGrammar"] not in ("Markdown", "Plain Text"):
@@ -32,6 +81,10 @@ def convert_note(self, draft):
             original_id=draft["uuid"],
         )
 
+        wikilink_note_links = self.handle_wikilink_links(note_imf.body)
+        draft_note_links = self.handle_drafts_links(note_imf.body)
+        note_imf.note_links = wikilink_note_links + draft_note_links
+
         if draft.get("flagged", False):
             note_imf.tags.append(imf.Tag("drafts-flagged"))
 
@@ -45,5 +98,10 @@ def convert_note(self, draft):
     def convert(self, file_or_folder: Path):
         input_json = json.loads(file_or_folder.read_text(encoding="utf-8"))
 
+        # first pass: for internal links, we need to store the note titles and IDs
+        for draft in input_json:
+            self.note_id_title_map[draft["uuid"]] = self.get_title(draft["content"])
+
+        # second pass: convert the notes
         for draft in input_json:
             self.convert_note(draft)

jimmy/writer.py

@@ -210,9 +210,16 @@ def update_note_links(self, note: imf.Note, note_link: imf.NoteLink):
                 f'Note "{note.title}": could not find original link: "{note_link.original_text}"'
             )
 
-        link_title = note_link.title if note_link.title not in [None, ""] else note_link.original_id
-
         new_path = self.note_id_map.get(note_link.original_id)
+
+        # find the best note title
+        if note_link.title not in [None, ""]:
+            link_title = note_link.title
+        elif new_path is not None:
+            link_title = new_path.stem
+        else:
+            link_title = note_link.original_id
+
         if new_path is None:
             LOGGER.debug(
                 f'Note "{note.title}": could not find linked note: "{note_link.original_id}"',

test/data

@@ -159,7 +159,7 @@ def format_test(self, test_input: Path):
             [["day_one/test_2/dayone-to-obsidian.zip"]],
             [["day_one/test_3/Export-Tagebuch.zip"]],
             [["diaro/test_1_frontmatter/Diaro_20250821.zip"]],
-            [["drafts/test_1_frontmatter/DraftsExport.draftsExport"]],
+            [["drafts/test_1_frontmatter/Drafts-2025-09-21-21-50.draftsExport"]],
             [["dynalist/test_1_frontmatter/dynalist-backup-2024-04-12.zip"]],
             [["evernote/test_1_frontmatter/obsidian-importer"]],
             [["evernote/test_2/joplin"]],