Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Commit 89e8d13

Browse files
authored
fix(logger): cleaning up unused parameters in logger setup (#1521)
1 parent 015a430 commit 89e8d13

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

config/lib/logger.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ logger.stream = {
3737
/**
3838
* Instantiate a winston's File transport for disk file logging
3939
*
40-
* @param logger a valid winston logger object
4140
*/
42-
logger.setupFileLogger = function setupFileLogger(options) {
41+
logger.setupFileLogger = function setupFileLogger() {
4342

4443
var fileLoggerTransport = this.getLogOptions();
4544
if (!fileLoggerTransport) {
@@ -72,13 +71,9 @@ logger.setupFileLogger = function setupFileLogger(options) {
7271
*
7372
* Returns a Winston object for logging with the File transport
7473
*/
75-
logger.getLogOptions = function getLogOptions(configOptions) {
74+
logger.getLogOptions = function getLogOptions() {
7675

7776
var _config = _.clone(config, true);
78-
if (configOptions) {
79-
_config = configOptions;
80-
}
81-
8277
var configFileLogger = _config.log.fileLogger;
8378

8479
if (!_.has(_config, 'log.fileLogger.directoryPath') || !_.has(_config, 'log.fileLogger.fileName')) {
@@ -141,6 +136,6 @@ logger.getLogFormat = function getLogFormat() {
141136
return format;
142137
};
143138

144-
logger.setupFileLogger({});
139+
logger.setupFileLogger();
145140

146141
module.exports = logger;

0 commit comments

Comments
 (0)